DanielRudrich / ABComparisonPlugin

An audio-plugin for multi-channel AB-comparison of several input signals.
GNU General Public License v3.0
13 stars 5 forks source link

It doesn't work on Windows #9

Closed Z-E-D closed 1 month ago

Z-E-D commented 2 years ago

I would like to use this plugin, but it doesn't work for me on Windows 7.

hectorC commented 2 months ago

Same problem for me. It doesn't work on Windows 11 using Reaper. Audio just passes through without any switching happening when pressing the buttons. I've doublechecked the track routing and it's all correct.

hectorC commented 2 months ago

I forked this project and updated the source code to the latest Juce SDK. It builds and it now works on Windows 11! At least with the 10 channels I tested. The release I posted is VST3 only since there seems to be no VST 2 SDK that can be legally obtained and used. The fork is located here: https://github.com/hectorC/ABComparisonPlugin

DanielRudrich commented 2 months ago

Thanks for looking into it! Will update the repo!

DanielRudrich commented 2 months ago

Upgraded JUCE to 8.0. Don't have a windows machine at hand right now to test...

Here's the latest build: https://github.com/DanielRudrich/ABComparisonPlugin/actions/runs/9505933847/artifacts/1599662893

hectorC commented 2 months ago

Upgraded JUCE to 8.0. Don't have a windows machine at hand right now to test...

Here's the latest build: https://github.com/DanielRudrich/ABComparisonPlugin/actions/runs/9505933847/artifacts/1599662893

Thank you for looking into it. I tested it and now the selection works! The only problem is that now the UI doesn't resize with Reaper's window, the way your previous VST2 version and my VST3 build does. I would also suggest to incorporate the pull request (now closed: https://github.com/DanielRudrich/ABComparisonPlugin/pull/8) that fixed the plugin capturing the keyboard after interacting with it, otherwise you have to click outside the plugin window to be able to control Reaper with the keyboard. The fork I did included that patch and it seemed to work well.

image

VST3 resizing:

image
DanielRudrich commented 2 months ago

Seems #8 has automatically been closed by me renaming the master branch to main. But I've added the changes now, unconsumed keypress no bubble up to the host.

I've added a ResizableCornerComponent so it's possible to resize the VST2 version. I kind of don't want to add VST3 as a default target because of its channel limitations :-/

hectorC commented 2 months ago

Seems #8 has automatically been closed by me renaming the master branch to main. But I've added the changes now, unconsumed keypress no bubble up to the host.

I've added a ResizableCornerComponent so it's possible to resize the VST2 version. I kind of don't want to add VST3 as a default target because of its channel limitations :-/

Great, thank you! Do you have an updated build of the VST2 to test?

DanielRudrich commented 2 months ago

Sure! https://github.com/DanielRudrich/ABComparisonPlugin/actions/runs/9530183431/artifacts/1605081088

hectorC commented 2 months ago

Thank you. Everything working great on Windows now!