Some look & feel updates, originally in a master branch commit, moved to Development

DanielScholte / GuildWars2Companion

GW2 Companion is an unofficial open-source Guild Wars 2 app. GW2 Companion helps you keep track of your account progression and characters, and provides information to help you on your journey in Tyria.

GNU General Public License v3.0

63 stars 14 forks source link

Some look & feel updates, originally in a master branch commit, moved to Development #51

Closed apcro closed 4 years ago

apcro commented 4 years ago

Description

Shrink a lot of larger image assets (new compression)
Update Inventory page to include a Divider() between the bag header and contents, if the bag has items in it.
Update Wallet to use alternate row background colours to make it easier to read.

Notes

Originally part of a different pull request (https://github.com/DanielScholte/GuildWars2Companion/pull/47) now closed unmerged.

DanielScholte commented 4 years ago

Looks good! Is it alright if I mention your GitHub name in the changelog within the app and on the app/play store?

apcro commented 4 years ago

Looks good! Is it alright if I mention your GitHub name in the changelog within the app and on the app/play store?

Of course :) I've been waiting for you to open source this app for a while so I could contribute, and there's more issues I'm working on in other local branches too :)

DanielScholte commented 4 years ago

Sounds great :)
Please keep in mind that normally you should create an issue before starting development or making a pull request. This is to discuss the changes first and to prevent conflicts regarding two people working on the same feature.