apcro
commented
3 years ago
- The API returns the flags in a string array. I'd recommend to convert this string array to a string list, instead of to multiple booleans. You can store this string list inside of the Item class instead of a seperate class.
if (json['flags'] != null { this.flags = json['flags'].cast<String>(); }
- You can then also save the flags as a TEXT inside the database, which can be the String list joined with semicolons.
flags TEXT
I'll modify the code to do it this way, but retain the boolean structures for now - discussion below :)
- Also keep in mind that you shouldn't edit the _initializationScripts of a migration. Instead, add a new query under _migrationScripts where you add the additional column.
I'll update this - this is a learning piece for me.
- Lastly, on the item page, you can do something like this:
I'll implement the flags code in this way, however I think this may miss context when displaying flags.
Discussion: Any item retrieved could have multiple flags, and the context for displaying information I think is important rather than just displaying all flags blindly.
One of my test objects, "Communal Boost Bonfire" (id 41741) has multiple flags not all of which may be useful information in all contexts: accountBindOnUse, deleteWarning, noMysticForge, noSalvage, noSell, noUnderwater.
In the context of the Bank tab, it's probably not be useful to show deleteWarning and noUnderwater. In the Bank context as well, despite accountBound not being set, if an accountBindOnUse flag is true and the item is in the bank, then it's likely also account bound so displaying that message rather than the 'bound on use' message might be clearer.
In another example, the item "Jurah's Jewel" has the flags hideSuffix and notUpgradeable, which again might not be useful information in the context of the Bank, but may be useful in other item contexts (for example, notUpgradeable would be useful information on the Equipment page.)
For soul bound items, the flag soulBindOnUse would translate as a straight 'Soul bound' message if the item was in the character's Equipment roster, but not necessarily if it was in the Bank
DanielScholte
Description
When getting item details from the API, also retrieve and store the available item flags.
These come as a list of strings, which are converted and stored in the ItemFlags object as booleans, and then stored in the database as Integers. On retrieval, the stored Integers are converted back to boolean for use in item display.
An example of extending item information display has been implemented in the Bank view, with Bank items displaying some additional information based on the Flags (such as Account Bound, Soul Bould, Unique etc). If an item being view has additional flags from the configured list, they will be displayed underneath a divider.
How Has This Been Tested?
Tested in-app using a real player account, viewing the additional information displayed.
Notes
Dart in Flutter doesn't support reflection, so the ItemFlags object is generated manually based on the list of possible strings returned by the API.