DanielSeehausen / fi-field-day

Flatiron WSServer for Hackathon
4 stars 6 forks source link

Python client #46

Closed MinesJA closed 6 years ago

MinesJA commented 6 years ago

Finished all clients: Ruby, Node, Python.

Currently, they don't have error handling. I'll add those features for each client later, but wanted to just get the clients up and running.

Each of them connect to the endpoints provided by Steven. Just missing the '/get-rect' endpoint. Once I get that I'll add that in. Each of them provide the methods:

realAndrewCohn commented 6 years ago

@MinesJA looks like we have some merge conflicts--could be due to nexus being merged in. Do we have /get-rect endpoint now?

DanielSeehausen commented 6 years ago

this looks great @MinesJA thank! Please resolve merge conflicts and reping after! if possible, please turn off these linters in your ide which make minor changes like removing extra whitespaces off the end of lines. just keeps the pr cleaner and from displaying changes that are only aesthetic to untouched files

MinesJA commented 6 years ago

Will take a look at this today.

On Mon, Aug 27, 2018 at 5:31 PM Daniel Seehausen notifications@github.com wrote:

this looks great @MinesJA https://github.com/MinesJA thank! Please resolve merge conflicts and reping after! if possible, please turn off these linters in your ide which make minor changes like removing extra whitespaces off the end of lines. just keeps the pr cleaner and from displaying changes that are only aesthetic to untouched files

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DanielSeehausen/fi-field-day/pull/46#issuecomment-416375599, or mute the thread https://github.com/notifications/unsubscribe-auth/AdTlyOx_AK4tvfI74WVMyo9J3lm7xbTRks5uVGUagaJpZM4V9Hn8 .