DanielSeehausen / fi-field-day

Flatiron WSServer for Hackathon
4 stars 6 forks source link

Style and help modal update #69

Closed DanielSeehausen closed 6 years ago

DanielSeehausen commented 6 years ago

pending @Gonzodamus approval

Dick-Ward commented 6 years ago

I've incorporated a lot of the stylistic changes from this into a new PR. This request breaks the zoom and contains a few redundancies, like the modal. It looks like you did a lot of organization/deletion though. Rather than update this one (which I would recommend closing), it seems better for organization that this all be done in a separate PR.

realAndrewCohn commented 6 years ago

Does #71 address everything from this PR? If so, can we close?

@Gonzodamus @DanielSeehausen

DanielSeehausen commented 6 years ago

sorry for the lack of communication here - both dick and I were mindmelding and writing stuff at the same time (uncanny really, as a lot of the stuff was literally exactly the same). if you can, clone this one down and take a look at the help modal action. if you don't like it we can move it to the bottom right, but my hope was that it is something that is only up for a quick reference then gone again just as easily. want to keep the board as sexy and pure looking as possible.

DanielSeehausen commented 6 years ago

image

DanielSeehausen commented 6 years ago

actually changed font take a look at this one:

image

DanielSeehausen commented 6 years ago

the ? with circle that you added (svg) is still there, just fades out on click, and back in on unfocus of the help menu

Dick-Ward commented 6 years ago

Personally I would rather have the instructions out of the way for quick reference. That way I can have them open if I want. The center modal gives you no choice but to interrupt what you're doing to reference the keybindings.

If you really insist on center, it should be able to be closed by clicking on it. Currently it's a little unintuitive

DanielSeehausen commented 6 years ago

ok @Gonzodamus excellent points -- will move it, remove the hide on blur functionality, and add in the X at the top.

DanielSeehausen commented 6 years ago

(before saturday)

realAndrewCohn commented 6 years ago

are we good to delete this branch since it's been merged in?