DanielT / NitroHack

A fork of NetHack 3.4.3
nitrohack.org
21 stars 2 forks source link

Wrong glyph blinked on Linux #16

Closed tung closed 12 years ago

tung commented 12 years ago

When multiple things are on a single tile, they should blink between each other. Instead, they seem to blink between the top-most thing and the first non-blinking tile to their left.

Below are the two frames of blinking where the player has just entered a leprechaun hall, with the leprechauns standing on piles of gold.

Looks okay. Not so okay.

This also happens when standing on anything (blinks the wall/floor to the left), or if a pet does the same, or if the pet and player stand next to each other and one is standing on something.

This happens on the latest 4.0.x commit (5ec05b6d927115db6f9f71987cdfa5bfc6b1e251) on Linux, but does not happen with the Windows 4.0.3 binary install.

DanielT commented 12 years ago

An unfortunate side effect of inadvertently accessing an array using a negative index... Fixed with commit 8276e19dd5077b7ebd06a27f4f49bfefa541643e