Grayscale correct and consistent? - Githubissues

DanielTakeshi / Algorithmic-HRI

1 stars 0 forks source link

Grayscale correct and consistent? #2

Closed DanielTakeshi closed 7 years ago

DanielTakeshi commented 7 years ago

Just realized, I need to ensure that the frames are converted to grayscale in a manner that is consistent with the current way in spragnur's code! It looks like he uses ale.getScreenGrayscale.

Edit: ahh, and having to ensure that my images take the 'max' over two consecutive frames. Spragnur's code indeed does that.

So in all I need to check:

grayscale conversion same during data generation from human gameplay [TODO],
taking max over consecutive frames during data generation from human gameplay [TODO]
(also) ensuring that I use a frame skip of 4 only [Done, already inserted in code, but data not udated]

to make sure the networks are taking consistent inputs.

DanielTakeshi commented 7 years ago

Resolved with 6eabe09e582c074128430ed913d0bc63818f2a26 and 88acb39de4be0fd5a372d73d7c5422d797a2b33f

See also https://groups.google.com/forum/#!topic/arcade-learning-environment/JHKeYxTzxvo