search

DanielVNZ / Whiteness-Toggle

0 stars 0 forks source link

Actual "Toggle" Function #1

Closed brendeni1 closed 1 month ago

brendeni1 commented 1 month ago

I love the mod so far-it's doing everything Legacy Flavour left behind. I suggest making the toggle behave like a real toggle switch in the sense that impressive Shift + W would turn the whiteness view on and off.

Where the mod stands right now, the whiteness disappears and there is no way to re-enable (it other than exiting and re-entering the mode). Being able to press Shift + W again to see the whiteness would be great (example: seeing wind direction arrows).

Also ensure that, if this feature is implemented, the mod remembers which mode you had on last. For example, having whiteness toggled off, exiting zoning and re-entering zoning mode should keep whiteness toggled off, rather than just turning the whiteness back on. The whiteness should stay persistent across tools when turned off with one.

Thanks!

DanielVNZ commented 1 month ago

Confirm is now fixed :)

will remember what you had last + key bindings are in!

DanielVNZ commented 1 month ago

(hopefully) let me know if any issues :)

brendeni1 commented 1 month ago

(hopefully) let me know if any issues :)

It's working great man! Just a quick question... I don't know the intricacies of Cities Skylines modding but is there any reason as to why you need to re-open the info view for the overlay to take effect? Mods like Legacy Flavour didn't require this. (Because of LF using Gooee maybe?)

Thanks for the mod though it makes the game leagues more playable.

DanielVNZ commented 1 month ago

Hey ya! great to here!

It might be possible but a tad out of my knowledge range aha. Ill do some digging! hopefully it might be as simple as using a different update method :)

DanielVNZ commented 1 month ago

Looking at Legacy Flavor's code, I do it basically the same way. I just tried a version with trigger update and sadly works identically as to how it works now (using the same update phases as Legacy Flavor)

https://github.com/Cities2Modding/LegacyFlavour/blob/2a4acaaec0a7405670f60020894970e0c4218e4c/LegacyFlavour/Systems/LegacyFlavourSystem.cs#L262

However, if you have any ideas id be happy to try them out :)

(may just be a game thing)

brendeni1 commented 1 month ago

Looking at Legacy Flavor's code, I do it basically the same way. I just tried a version with trigger update and sadly works identically as to how it works now (using the same update phases as Legacy Flavor)

https://github.com/Cities2Modding/LegacyFlavour/blob/2a4acaaec0a7405670f60020894970e0c4218e4c/LegacyFlavour/Systems/LegacyFlavourSystem.cs#L262

However, if you have any ideas id be happy to try them out :)

(may just be a game thing)

Interesting. I'll never understand some of the things that Colossal Order changes lol.

Thanks for the info though! I'll be enjoying the mod :)