DanielVanNoord / open-phd-guiding

Automatically exported from code.google.com/p/open-phd-guiding
0 stars 0 forks source link

PHDLab cannot interpret special characters in PHD2 logfile #228

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run a logfile from PHD2 with PHDLab v0.5.1 with Mount = EQMOD HEQ5/6 ("/" is 
a special character)

What is the expected output? What do you see instead?
You should see the guiding entries, but you see only the calibrations.

What version of the product are you using? On what operating system?
PHD2 Beta3 (r561), Windows 8.1

Please provide any additional information below.

If you remove the "/" (or replace it with 5 6) from the PHD2 logfile, then 
PHDLab displays guiding entries correctly. John Wainwright is informed. I think 
it is better to fix the problem at the source (PHD2), to avoid problems in 
other 3:rd party programs.

Original issue reported on code.google.com by jan.schn...@gmail.com on 15 Dec 2013 at 10:24

GoogleCodeExporter commented 9 years ago
Jan,

Could you describe the specific set of characters (of which '/' is a member) 
that PHDLab is not prepared to handle?

We need to understand the full set of "special" characters (and any other 
limitations of the PHDLab parser) to ensure PHD2 is compatible.

Also, if we can see the full set we can have more information to decide whether 
we are in agreement that this is something that needs to be addressed in PHD2 
vs in PHDLab.

Thanks,
Andy

Original comment by andy.gal...@gmail.com on 16 Dec 2013 at 12:54

GoogleCodeExporter commented 9 years ago
I'm not certain this is a PHD2 bug.  I understand the desire to fix things at 
the source, but unless we create (and enforce) a list of characters that are 
not valid in the log file, we can't do more than fix this as things get entered 
by other people. We get the name of cameras and mounts from ASCOM, and it seem 
like programs that read the log need to be prepared for special characters, 
I18N characters, and pretty much all other unicode charcters.

Original comment by br...@boneheads.us on 16 Dec 2013 at 1:13

GoogleCodeExporter commented 9 years ago
Hi Andy and Bret

I have only checked the "/" charachter, because removal of it solved my problem 
with PHDLab. But I assume that PHDLab has a problem with special characters. If 
PHD2 gets the mount-info directly from other sources, Bret is right not to deal 
with this problem in PHD2. I assumed those strings were in the PHD2 code.

Please turn directly to John Wainwright in the "Open PHD Guiding" Group(author 
of PHDLab) and  discuss this with him. I told him 29.10.2013 about this 
problem, and he would provide a patch sometime...

cheers / Jan

Original comment by jan.schn...@gmail.com on 17 Dec 2013 at 7:47

GoogleCodeExporter commented 9 years ago
Thanks Jan. I'm closing this as Won't Fix. If we get more info from John in the 
future about what he needs from PHD we can open a new issue (or re-open this 
one) at that time.

Original comment by andy.gal...@gmail.com on 17 Dec 2013 at 7:52