search

DanielVanNoord / open-phd-guiding

Automatically exported from code.google.com/p/open-phd-guiding
0 stars 0 forks source link

Code review request #250

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:

     Adding Mac OS X support for the KWIQGuider.

When reviewing my code changes, please focus on:

     This code is based on an openssag code link that Craig gave me.  As the two cameras are virtually identical
     other than VID/PID, most of the changes just involved creating a new name space.  It seems to be working;
     although I haven't extensively tested it (too frigging cold/snow - I did get out one night though).

     One concern is that several of the files from Craig had no copyright or usage comment headers, and I 
     wasn't sure what was appropriate (so they still don't).

     Also, if one goes poking around into OS USB properties, one would see that the firmware actually temporally
     changes the identity of the camera to openssag.

After the review, I'll merge this branch into:

/trunk

Original issue reported on code.google.com by wjbl...@comcast.net on 28 Jan 2014 at 7:16

GoogleCodeExporter commented 9 years ago 
I think this is best followed-up by Brett -> reassigning to Brett.
Brett : if this is wrong then please reassign as you see fit :)

Original comment by h...@dse.nl on 7 May 2014 at 10:37

GoogleCodeExporter commented 9 years ago 
sorry, i meant Andy -> reassigning to Andy
Andy: if this is wrong then please reassign as you see fit :)

Original comment by h...@dse.nl on 7 May 2014 at 12:42

GoogleCodeExporter commented 9 years ago 
the code has been in trunk for quite a while though I never had a chance to 
review it. I'm just going to mark this as done to get it off the list.

Original comment by andy.gal...@gmail.com on 5 Sep 2014 at 5:01