DanielVanNoord / open-phd-guiding

Automatically exported from code.google.com/p/open-phd-guiding
0 stars 0 forks source link

SX-AO needs firmware version check #363

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Different SX AO firmware versions allow different ranges of travel for the AO.

PHD2 currently assumes the ao can move 45 steps in any direction. The firmware 
versions we know about:

version      limit (approx)
020          60
101          60
103          50
104          40

Even if the limit is 50, and the ao can move to (50,0), it may not necessarily 
be able to move to (50,50).

At a minimum phd2 should validate that it is using version <= 101.

Even better would be to adjust the assumed range at runtime based on the 
firmware version or by dynamically probing the range during calibration.

Dynamically probing the range may run the potential risk of jamming the AO, so 
it may be preferable to use the fixed limits based on the firmware rev.

Original issue reported on code.google.com by andy.gal...@gmail.com on 6 Nov 2014 at 7:38

GoogleCodeExporter commented 9 years ago
waiting to hear from Terry whether dynamically probing the range actually runs 
the risk of jamming the AO

Original comment by andy.gal...@gmail.com on 6 Nov 2014 at 8:08

GoogleCodeExporter commented 9 years ago
Terry does not think it is a bad idea to dynamically probe the range.

For now though, I am just going to put in a firmware version check.

Original comment by andy.gal...@gmail.com on 10 Nov 2014 at 4:22

GoogleCodeExporter commented 9 years ago

Original comment by andy.gal...@gmail.com on 10 Nov 2014 at 4:22

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r1267.

Original comment by andy.gal...@gmail.com on 10 Nov 2014 at 4:23