search

DanielVandH / ProfileLikelihood.jl

Methods for profile likelihood analysis.
MIT License
17 stars 3 forks source link

Compute full liklihood over parameter interval #91

Open TorkelE opened 7 months ago

TorkelE commented 7 months ago

Hello!

I am developing Catalyst.jl (https://github.com/SciML/Catalyst.jl) for systems biology modelling. Likelihood profiles are used in Systems biology for practical identifiability analysis, and in the community we are looking for a good Julia tool for computing this, and this package looks neat!

A question, is there (or would it be possible to get) and option for computing the full profile over an interval (p_start,p_end). Here, rather than having a confidence interval for the parameter, I would want to look at its full profile (which admittedly requires some more computation).

Does this make sense, and would this be something that could be supported?

DanielVandH commented 7 months ago

That shouldn't be too hard to implement. It might even be possible already if you set param_ranges appropriately with threshold=-Inf? Maybe you can check if that works.

If it doesn't work, I can try and find some time to get to it, although no guarantees just yet on when I might find the time (unless you want to work on a PR which I'm happy to assist with, although I really need to clean up the code significantly since it might be hard for you to read).

TorkelE commented 7 months ago

That shouldn't be too hard to implement. It might even be possible already if you set param_ranges appropriately with threshold=-Inf? Maybe you can check if that works.

This might work, I will play around with it. I'm playing around with the package right now, if I get familiar enough with it I could try make a PR at some point.