search

DanielYKPan / date-time-picker

Angular Date Time Picker (Responsive Design)
https://daniel-projects.firebaseapp.com/owlng/date-time-picker
MIT License
562 stars 358 forks source link

Please use semantic versioning #231

Open johankvint opened 6 years ago

johankvint commented 6 years ago

https://semver.org/

Concerning going from version 5.0.x to 5.1.x....

If you make major changes in you code that is not backward compatible, please consider changing the major version.

atom-morgan commented 6 years ago

The changes between 5.0 and 5.1 are staggering to say the least.

kazzkiq commented 6 years ago

To others who had broken code/UI after the update, simply update your package.json with the following:

...
"ng-pick-datetime": "5.1.0"
...

And re-run npm install.

This temporary workaround locks the version to 5.1.0 and prevents unexpected future compatibility issues, which is needed until the project uses SemVer.

itsnotvalid commented 6 years ago

If there was some guidelines for migrating it would also be great, in the case where certain events are removed (for example onSelect).