DanielaNy / Pyladies_Amsterdam_Capstone_Project

Team's 11 capstone project of Data Analysis Bootcamp 2020 organized by Pyladies Amsterdam
GNU General Public License v2.0
0 stars 0 forks source link

Pyladies Bootcamp Mentor Review #1

Open Victoriapm opened 4 years ago

Victoriapm commented 4 years ago

Hi Daniela (and team)!

Congrats on finishing the Bootcamp and the project!

Looking forward to seeing this presentation, it's impressive the variety of plots you've made, and great practice adding a key insight for each plot.

You're repository is missing just one more push: Merge (or delete) the files. It looks like you have created a new file for each change in the presentation and that you all worked in different notebooks and haven't merged into one single analysis notebook. Instead of creating a new file what you could do is to commit the changes, that way you can always go back to a previous version, the same way here you could go back to a previous file. And instead of creating multiple analysis notebooks you could have used branches and done a pull request. I understand how scary GitHub is at first (been there) and how hard is to collaborate during coding as a team. For the future, here are some useful guide for learning Github Other than that, my suggestions are:

Feel free to reach out if anything is not clear or you would like to discuss :)

DanielaNy commented 4 years ago

Thank you for a review, I am sure we all will remember all the advices in the future :)