Closed aburkhalter512 closed 4 years ago
Merging #331 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 92.48% 92.48%
=======================================
Files 77 77
Lines 1157 1157
Branches 6 6
=======================================
Hits 1070 1070
Misses 87 87
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 56296b6...3242f61. Read the comment docs.
@DanielaSfregola just to be clear do you want me to make state
optional as well?
Thanks for your super speedy review!
Hi @aburkhalter512, I wouldn't change it for now since the documentation does say that state
is always returned.
Of course, if we realize that this is not the case, we can change it to optional later! ;)
LGTM
I discovered that this field wasn't returned when
state == "pending"
soprocessing_info
wouldn't get deserialized. I did not makestate
optional since the twitter docs seem to indicate that ifprocessing_info
exists, then so doesstate
, but I could be convinced to make it optional anyways.