DanielaSfregola / twitter4s

An asynchronous non-blocking Scala client for both the Twitter Rest and Streaming API

Apache License 2.0

256 stars 100 forks source link

JSON4S to 3.7.0-M7 #358

Closed zzvara closed 3 years ago

zzvara commented 3 years ago

Spark 3.1.0 requires JSON4S 3.7.0-M1+, this will come in handy.

codecov[bot] commented 3 years ago

Codecov Report

Merging #358 (b4030c6) into master (ff5b165) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          77       77           
  Lines        1157     1157           
  Branches        6        6           
=======================================
  Hits         1070     1070           
  Misses         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff5b165...b4030c6. Read the comment docs.

zzvara commented 3 years ago

@DanielaSfregola could you publish a new version of this PR?

DanielaSfregola commented 3 years ago

Hi Zoltan, unfortunately we cannot update json4s to a milestone version: we need to rely on a stable version.

You still be able to force a version override if you need twitter4s to run with a specific version. Have you considered using a dependency override? see https://www.scala-sbt.org/1.x/docs/Library-Management.html#Overriding+a+version? (I am assuming you are using sbt).

Cheers, D.

zzvara commented 3 years ago

@DanielaSfregola sure, but there is a binary incompatibility. Twitter4S is looking for JSON4S with version 3.6.X. Instead of shading, we decided to publish a snapshot.

As I noticed, 3.7.0-MX has been around for nearly a year (?) and a lot of projects depend on it, including Spark 3.1.0. We depend on it as well in production.

DanielaSfregola commented 3 years ago

Ok, that changes things! It they have been having milestone versions for 1y and spark depends on it, then I think it is safe enough to update.

DanielaSfregola commented 3 years ago

merged, I'll do my best to do a release during the weekend :)

DanielaSfregola commented 3 years ago

Ok, this took way more than I expected! I have released 7.1, it will be in maven central in a couple of hours!

Please, let me know if anything goes wrong - unfortunately Sonatype was having a bad day, so hopefully I didn't mess it up too much.

Cheers, Daniela