DanielaSfregola / twitter4s

An asynchronous non-blocking Scala client for both the Twitter Rest and Streaming API
Apache License 2.0
256 stars 100 forks source link

Support for full-archive / academic research track endpoints #368

Closed TheConner closed 2 years ago

TheConner commented 3 years ago

Decouples Client from OAuthClient in order to support bearer-token authentication. Thus, we can use Bearer-token authentication for endpoints like this one

Related to #366

TheConner commented 3 years ago

Build failed :confused: we are having a classic scenario of "it works on my machine" ... I'll investigate

DanielaSfregola commented 3 years ago

Thanks for updating the PR - unfortunately there are still some stylistic issues to solve - for example the use of .get and some code duplication in the authentication clients

I'll see if I can polish it off this weekend :)

{ you can follow my progress on this branch: https://github.com/DanielaSfregola/twitter4s/tree/368_followup }

TheConner commented 3 years ago

Sounds good to me. Let me know if there's anything else I can do, for now I'm adding some extra features to the new endpoint which I needed for my research, so after you're done your changes I can probably integrate the additional endpoint functionality in. Or, alternatively, that may be another PR :wink:

DanielaSfregola commented 2 years ago

Closing this in favour of the follow up I am started -- see https://github.com/DanielaSfregola/twitter4s/tree/368_followup