DanielaSfregola / twitter4s

An asynchronous non-blocking Scala client for both the Twitter Rest and Streaming API
Apache License 2.0
256 stars 101 forks source link

Split V2 Deserialization tests from Query Building Tests #414

Closed ConnorSinnott closed 2 years ago

ConnorSinnott commented 2 years ago

Since Twitter now offers standardized responses for V2 queries, testing that each client can correctly deserialize a standardized response seems redundant. We know that tweet endpoints will return either a TweetResponse or TweetsResponse, similarly the user endpoints a UserResponse or UsersResponse, so can break our tests into query building vs deserialization.

ConnorSinnott commented 2 years ago

@DanielaSfregola here are the changes I proposed in #411