search

DanielaSfregola / twitter4s

An asynchronous non-blocking Scala client for both the Twitter Rest and Streaming API
Apache License 2.0
256 stars 100 forks source link

Add Place and Poll support #423

Closed ConnorSinnott closed 3 years ago

ConnorSinnott commented 3 years ago

Adds materialization support for the Place and Poll fields.

ConnorSinnott commented 3 years ago

Hey @DanielaSfregola, is there a way for me to see whats causing these CircleCI failures?

DanielaSfregola commented 3 years ago

Hey @DanielaSfregola, is there a way for me to see whats causing these CircleCI failures?

https://app.circleci.com/pipelines/github/DanielaSfregola/twitter4s/28/workflows/10daaefe-ad76-471d-85b1-448232f9fb44/jobs/30

[info] Checking formatting for 272 Scala sources in root:compile ...
[error] /home/circleci/repo/src/main/scala/com/danielasfregola/twitter4s/entities/v2/Poll.scala has changes after scalafmt
[error] /home/circleci/repo/src/main/scala/com/danielasfregola/twitter4s/http/serializers/CustomFormats.scala has changes after scalafmt
[error] com.lucidchart.sbt.scalafmt.ScalafmtCheckFailure: 2 Scala sources not formatted in root:compile

To fix it, all you need to do is run "sbt test:compile" (ask sbt to compile the src code and the tests) and the files will be formatted correctly automatically

ConnorSinnott commented 3 years ago

Awesome! Got those corrected! Ready for your review now.