Danielededo / SagradaFamilia

Software Engineering Project 2017/2018 @Polimi
Apache License 2.0
1 stars 0 forks source link

code in a cleaner way #6

Closed ingconti closed 6 years ago

ingconti commented 6 years ago

You wrote:

   for (int i=0;i<4;i++){
        for (int j=0;j<5;j++){
            string += scheme[i][j].toString()+ "\t";

but at top You have:

private  static final int width = 4;
private static final int height = 5;

4 and 5 are the same?

mariodiodoardo commented 6 years ago

7c08dab5-2e37-4670-b748-9e2ea1d3eb05 yes we've just done it as shown in the picture but we need to commit it

ingconti commented 6 years ago

commit and I will close.

Danielededo commented 6 years ago

committed

ingconti commented 6 years ago

ok, but You have a a lot of similar code. pls review it; example:

public int calcola_punteggio(Player player) {
    int cont=0;
    for (int i=1;i<3;i++){
        for (int j=1;j<4;j++){