search

Danielhiversen / PyXiaomiGateway

PyXiaomiGateway
MIT License
152 stars 55 forks source link

Improve naming #197

Closed starkillerOG closed 1 year ago

starkillerOG commented 1 year ago

Thanks to the comments of MartinHjelmare in this PR: https://github.com/home-assistant/core/pull/74979

starkillerOG commented 1 year ago

@Danielhiversen would you be so kind to merge this?

starkillerOG commented 1 year ago

@Danielhiversen This is a very simple PR just renaming a few constants for clarification. Could you please merge this?

Or maybe provide me with write acces to the PyXiaomiGateway library (and the pypi account)?

starkillerOG commented 1 year ago

@syssi could you merge this very simple PR?

syssi commented 1 year ago

It took me some minutes to understand the return value of create_datagram_endpoint.

A tuple of (transport, protocol) is returned on success.

https://docs.python.org/3/library/asyncio-eventloop.html