search

Danielhiversen / flux_led

A utility for controlling Flux WiFi Smart LED Light Bulbs
GNU Lesser General Public License v3.0
156 stars 143 forks source link

Breakout timers into the protocol module #300

Closed bdraco closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #300 (d1e6ba3) into master (ebde627) will increase coverage by 3.45%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   87.92%   91.37%   +3.45%     
==========================================
  Files          15       15              
  Lines        2865     2945      +80     
==========================================
+ Hits         2519     2691     +172     
+ Misses        346      254      -92
Impacted Files Coverage Δ
flux_led/device.py 63.50% <9.09%> (+6.99%) :arrow_up:
flux_led/timer.py 56.41% <69.56%> (+36.68%) :arrow_up:
flux_led/protocol.py 97.65% <87.30%> (-1.06%) :arrow_down:
flux_led/aiodevice.py 99.28% <100.00%> (+0.04%) :arrow_up:
flux_led/pattern.py 100.00% <100.00%> (ø)
flux_led/base_device.py 98.43% <0.00%> (+0.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebde627...d1e6ba3. Read the comment docs.

bdraco commented 2 years ago

Timers are still wrong on the sockets