search

Danielku15 / BetterStartPage

A Visual Studio like start page which replaces the news section by a custom project dashboard.
47 stars 19 forks source link

Broken again after 15.6 installed. Looks like the similar issue as it was after 15.5 #32

Closed slcoleg closed 6 years ago

slcoleg commented 6 years ago

Thanks a lot

SirViver commented 6 years ago

Seems like the XAML bindings have changed yet again :(

I'm really out of my depth when it comes to this whole binding thing, however one issue I could identify and sort of fix in my local fork is that the codeContainerAccessManagerConstructor in the VisualStudio2017StartPage static constructor code now takes an IAsyncServiceProvider ctor parameter instead of a regular IServiceProvider.

Changing the code to resolve and supply one of those at least fixes the NullReferenceException and makes the main Favorites panel show up. However, the "Open", "New project", and "Recent" sections remain empty with just these changes - I suspect fixing the XAML bindings would resolve the rest.

Edit: Actually it turns out I just implemented it incorrectly. Adding the async service provider exactly like it is already done for the newProjectsListViewModelConstructor fixes the issue.

Danielku15 commented 6 years ago

Thanks for the Info. I try to provide a fix by today.

Danielku15 commented 6 years ago

@SirViver was right, they moved from the classical IServiceProvider to IAsyncServiceProvider. I added a fix and deployed a new extension version to the marketplace.