search

Danielsio / Plan-IT-Web

An application that prepares smart study schedules for students during exam periods.
https://plan-it-web-seven.vercel.app/
1 stars 2 forks source link

Add SlideShow to HomePage #81

Closed Danielsio closed 1 year ago

Danielsio commented 1 year ago

Description

Added SlideShow component to the homepage The component contains effects from 3rd party react library

Relevent issues:

close #30

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plan-it-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 6:44pm
Danielsio commented 1 year ago

Hey Team, let me know if you think something is missing, or can I do something extra to make this PR Merge-Ready ASAP.

oshriFadlon1 commented 1 year ago

I opened the site in the preview and I don't see the arrows on the pictures

Danielsio commented 1 year ago

I opened the site in the preview and I don't see the arrows on the pictures

Can you please spot on the code what needs to be changed to fix this problem ?

itayf9 commented 1 year ago

Hey Team, let me know if you think something is missing, or can I do something extra to make this PR Merge-Ready ASAP.

Well, I still think there are UI improvements need to be done before merging (not your fault, probably the 3rd party package's fault). First, the text of "Before" and "After" is not looking so good. Second, that green border (can live with it but prefer to remove it). Third, no arrows are shown to move between the images, but there are such buttons in the edges of the images.

Anyway, I've found a nice 3rd party that may be better (I haven't tried it yet), called "React SlideShow". https://react-slideshow-image.netlify.app/?path=/docs/examples-fade--default

Danielsio commented 1 year ago

Hey Team, let me know if you think something is missing, or can I do something extra to make this PR Merge-Ready ASAP.

Well, I still think there are UI improvements need to be done before merging (not your fault, probably the 3rd party package's fault). First, the text of "Before" and "After" is not looking so good. Second, that green border (can live with it but prefer to remove it). Third, no arrows are shown to move between the images, but there are such buttons in the edges of the images.

Anyway, I've found a nice 3rd party that may be better (I haven't tried it yet), called "React SlideShow". https://react-slideshow-image.netlify.app/?path=/docs/examples-fade--default

indeed the link you send demonstrates well wrriiten slideshow.. i will give it a try

Danielsio commented 1 year ago

Hey Team, let me know if you think something is missing, or can I do something extra to make this PR Merge-Ready ASAP.

Well, I still think there are UI improvements need to be done before merging (not your fault, probably the 3rd party package's fault). First, the text of "Before" and "After" is not looking so good. Second, that green border (can live with it but prefer to remove it). Third, no arrows are shown to move between the images, but there are such buttons in the edges of the images.

Anyway, I've found a nice 3rd party that may be better (I haven't tried it yet), called "React SlideShow". https://react-slideshow-image.netlify.app/?path=/docs/examples-fade--default

oshriFadlon1 commented 1 year ago

the picture not site good in the frame they have. It cut half of the last day in the picture.

Danielsio commented 1 year ago

the picture not site good in the frame they have. It cut half of the last day in the picture.

yea, it did

oshriFadlon1 commented 1 year ago

The pictures are not sharp You can't see what is written on them

Danielsio commented 1 year ago

The pictures are not sharp You can't see what is written on them

thing is with the original picture, you get 80% picture and the content get cut off, like you saw previously. Maybe if can you get those images with a bit zoom out and still better sharpness it will look good enough.

alternatively, if you can find a way to fix up the scaling part, or get a good slideshow component from a library that's looks good it will be great.

notice the first 3 commits of this pr is the same implementation of the slideshow but from diffrent libraries.

i personally grew tired of this feature since all the implementations i have seen arent something that blew my mind.. compare to other well styled websites