search

Danktuary / vuepress-theme-yuu

A VuePress 1.x theme that supports a dark theme, multiple color themes, and other useful features.
https://vuepress-theme-yuu.netlify.com/
MIT License
72 stars 7 forks source link

Some improvements #11

Closed rogeraabbccdd closed 4 years ago

rogeraabbccdd commented 5 years ago
Danktuary commented 5 years ago

Hi, sorry for the late reply. I cloned your changes locally to test them out but I think there's something wrong with the defaultDarkTheme option.

My config:

Result:

The default theme is still white. Another thing I noticed is that if I set the defaultTheme to 'blue' but then decide I want it to be 'green' instead (or supply something like null), it stays as blue after refreshing.

Could you look into those things? Or if you can't figure it out, let me know so that I can give it a go. Thanks!

rogeraabbccdd commented 5 years ago

Hello, defaultDarkTheme is working for me. What's your vuepress version?

Danktuary commented 4 years ago

Hey, sorry for replying once and then never again. 😅 I started working on the 2.x version of it in the meantime and added a few other options, fixes, and updates. I rewrote most of the theme to use VuePress@^1's theme inheritance feature, which is probably what caused the merge conflicts to this PR. I added the defaultDarkTheme and defaultColorThemes options recently, so if you're still interesting in using the theme, I'd recommend updating to vuepress-theme-yuu@^2.2.0. Sorry again and thanks for the PR!