Add theme options label customization

Danktuary / vuepress-theme-yuu

A VuePress 1.x theme that supports a dark theme, multiple color themes, and other useful features.

https://vuepress-theme-yuu.netlify.com/

MIT License

72 stars 7 forks source link

Closed System-Glitch closed 4 years ago

System-Glitch commented 4 years ago

Related to #18

This PR adds two new configuration entries:

labels.darkTheme: the label shown in the Theme settings for the dark theme toggle
labels.forcedThemes: the label shown in the Theme settings for the ignore forced theme toggle

Danktuary commented 4 years ago

Hey, thanks for the PR! Would you mind renaming the options to yuu.labels.darkTheme and yuu.labels.forcedThemes?

System-Glitch commented 4 years ago

@Danktuary I made the change. Tell me if you need anything else.

Danktuary commented 4 years ago

Commit it and I'll merge 😄

System-Glitch commented 4 years ago

@Danktuary e7d61ef

Danktuary commented 4 years ago

What about my other comment?

System-Glitch commented 4 years ago

What other comment? I changed the options names.

Danktuary commented 4 years ago

Oh, my fault 🤦🏻‍♂️ I forgot to submit the review