Provide raw data without modifying values like Country code, Currency etc.

DannielWhatever / emvqr

help to work with emv qr code specification for digital payments

10 stars 11 forks source link

Provide raw data without modifying values like Country code, Currency etc. #6

Open Lakshman1996 opened 3 years ago

Lakshman1996 commented 3 years ago

52 - Merchant Category Code 53 - Transaction Currency" 58 - Country Code

The decoded data for above ids contains extra value which is added to data for example: LK (Sri Lanka) for 58. If there is a an options object that decode method can take and return raw data that would be awesome

I am willing to submit a PR as well

Thanks

DannielWhatever commented 3 years ago

Hi, I just accepted your pull request, I will upload a version with your changes to npmjs, as soon as I have a little time I will review the issues. thanks for your contribution ;)

Lakshman1996 commented 3 years ago

The PR that I have submitted was for a different fix. However ill try to fix this when I get some free time.

Nice library BTW!

DannielWhatever commented 3 years ago

Oops, you are right! I just made a general refactor and push a new alpha version, this one emvqr@1.0.0-alpha.0 . With these changes I include the rawData field in every emvItem. I hope this will be useful for you.