DannyBen / madness

Instant Markdown Server
https://madness.dannyb.co
MIT License
128 stars 19 forks source link

Docker version 1.1.3 fails to start missing gem #163

Closed xorguy closed 8 months ago

xorguy commented 9 months ago

Hi.

Updated to latest 1.1.3 docker version and it fails to start: `Sinatra could not start, the "rackup" gem was not found!

Add it to your bundle with:

bundle add rackup

or install it with:

gem install rackup`

Is anything missing on my end?

DannyBen commented 9 months ago

Thanks for the report.... no - it is not a problem on your end. The Rack gem team has made quite a mess with this separation and the rack 3 update.

I will release a fix immediately.

It is weird that all tests pass...

DannyBen commented 9 months ago

I cannot reproduce the problem btw - when installing madness with gem install madness in a clean (docker) environment, it is working as expected.

I will nonetheless add rackup as a dependency.

DannyBen commented 9 months ago

What command are you running exactly?

I am running this, and it is working (on amd64 architecture):

$ docker run --rm -it dannyben/madness --version
1.1.3
DannyBen commented 9 months ago

Found the problem...

$ docker run --rm -it dannyben/madness serve
fails

Version 1.1.4 coming up - I will yank 1.1.3

DannyBen commented 9 months ago

Try version 1.1.4

$ docker pull dannyben/madness:1.1.4
$ docker run --rm -it dannyben/madness:1.1.4 serve

works for me

xorguy commented 9 months ago

Working here too.

Thank you!

DannyBen commented 9 months ago

Thanks for reporting - this particular bug is hard to test automatically...