Closed wburningham closed 1 year ago
Correct. Bug.
I found the problem - but due to the fact that snapcrawl relies on aging dependencies, it gets harder to maintain. Tests are failing, and I am not sure I have the energy for it.
Thanks for finding the problem. I'm no ruby/gem expert, but I can build my own docker images.
If I wanted to reference a commit from your PR to pull in the fix, what do I change on this line? https://github.com/DannyBen/docker-snapcrawl/blob/0c2405c9a15186eb28c52c265b7ea13b24548598/Dockerfile#L18C9-L18C16
You would have to change the line so that:
git clone
the repository and cd
into it.git checkout fix/css-selector
to switch to the PR branch.bundle
to install Ruby dependencies.bundle exec run gem build --install
to build and install the gem.I will either try harder to fix the failing tests, or archive the repository. The aging dependencies have no replacement.
Good news. Tests are passing. I will release a pre-release in a few, and if it works for you, I will release a version.
Awesome! Thanks for the fast turn-around time.
Awesome! Thanks for the fast turn-around time.
I either do it quickly or not at all :)
Version 0.5.4.rc1 is on rubygems Docker will take a few more minutes
Docker is also updated. If it works for you - I will release 0.5.4.
I just tested dannyben/snapcrawl:0.5.4.rc1
locally and it correctly captures using the css_selector
Alright. I will let it soak for the night and release a version tomorrow.
Fixed in version 0.5.4.
Let me know if I am just using the option incorrectly, but if not it seems like the
css_selector
option is not working.Command run
Expected outcome
Just have a screenshot of the main content rather than the entire page