DannyDainton / newman-reporter-htmlextra

A HTML reporter for Postman's Command Line Runner, Newman. Includes Non Aggregated Runs broken down by Iterations, Skipped Tests, Console Logs and the handlebars helpers module for better custom templates.
Apache License 2.0
357 stars 139 forks source link

[Bug] The theme toggle does not display the report in Dark mode on IE Edge #250

Closed srinivasskc closed 4 years ago

srinivasskc commented 4 years ago

Describe The Problem When i open the report on IE Edge and Click on Dark Mode toggle, It does display the report in dark mode.

Steps To Reproduce

  1. Run the collection 'newman run APITesting.postman_collection.json -r htmlextra'
  2. Open the report 'file:///C:/development/postman-api-testing-collection-1/newman/API%20Testing-2020-07-21-03-38-36-833-0.html'
  3. Select the Request view 'Dark Mode'

What Are You Seeing It displays the same report when Light Mode or Dark Mode is selected. No Background color changed.

Screenshots and Gifs image

Collection and Environment Files Environment: Windows 10 Browser: IE Edge latest version Collection: Any Collection

Version and Platform Information:

Additional Context

DannyDainton commented 4 years ago

Thanks for writing in! 🏆

Could you confirm the Newman version please @srinivasskc, that doesn't look quite right.

If you could share the node version too that would be great.

srinivasskc commented 4 years ago

Below are details @DannyDainton .

Node Version: 12.18.2 image

NPM Version: 6.14.6 image

Newman Version: 5.1.0 image

There is an error while executing this function while launching the report (either in light or dark mode). (function () { if (localStorage.getItem('theme') === 'theme-light') { setTheme('theme-light'); document.getElementById('slider').checked = false; } else { setTheme('theme-dark'); document.getElementById('slider').checked = true; } })();

Console Log Screenshot: image

image

No data is stored in Storage image

DannyDainton commented 4 years ago

There seems to be a lot of issues over the years with local storage and Edge. Even the latest update here was from last month :/

https://stackoverflow.com/questions/34798285/how-can-i-open-a-local-html-file-in-microsoft-edge-browser

DannyDainton commented 4 years ago

Just to confirm @srinivasskc - Apart from the report not flipping over to the Dark theme, is the rest of it functional?

Just want to ensure there isn't any other quirks of Edge that I haven't accounted for/seen yet. :(

srinivasskc commented 4 years ago

Thanks for asking. @DannyDainton I found a functionality issue.

Response Information is not displaying on IE Edge, whereas it displays information on Chrome. image

DannyDainton commented 4 years ago

Interesting 🤔

Might need a little bit more info that a static image of something that you can see on your machine though 😁

Any errors? Could you check the elements in the dev tools to see if it's just a CCS thing?

Could you share the collection files with me please?

srinivasskc commented 4 years ago

I have checked further, its more of CSS.

image

class .badge-success { color: #fff } which is strike off.

When i unchecked the property, Now values are displaying.

image

The same css property when strike off, it is displaying values on chrome. @DannyDainton

DannyDainton commented 4 years ago

Yeah I thought it all might be wrapped up with the CSS issues from the toggle changes.

I'm sure there will be more on Edge and to save you posting each one I would recommend not using that browser with the reporter. 😢

srinivasskc commented 4 years ago

You can close this ticket :) And also it would be good to see if you can add "Browser Compatability" in Readme file.

DannyDainton commented 4 years ago

Sounds like a great way to contribute to the project and get your name on it too.

If you makes the changes to the readme and send me a PR I will get it merged 😁

DannyDainton commented 4 years ago

@srinivasskc I'm going to close this for now but please do raise a PR for changes to the README, I would appreciate your contributions.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.