search

DannyDeGaspari / Samsung-HVAC-buscontrol

Protocol description of the serial communication channel of Samsung airconditioners.
GNU General Public License v3.0
68 stars 17 forks source link

Wrong Command 52 temperature deserialization (bit 6 secret ;-) #17

Closed pavelchuchma closed 2 weeks ago

pavelchuchma commented 1 year ago

Hi Danny, your doc tells about temperature in Command 52: 

bit 5-0 : set temperature - 9
bit 6 : always set to '1' ?

In reality it should be:

bit 6-0 : set temperature + 55

Detected & tested on my java HVAC Controller project during hot summer when AC air output was 8°C but original deserialization read it wrongly as 72°C.

Feel free to see this fix, especially the test method at the end.

DannyDeGaspari commented 1 year ago

Thanks for mentioning this ! I will update my docs.