search

DannyMoerkerke / whatpwacando.today

Repo to collect bugs for https://whatpwacando.today/
542 stars 7 forks source link

Pressing the `install to home screen` button then `close` renders scrolling useless #45

Closed gaber85 closed 8 months ago

gaber85 commented 8 months ago

On the iPhone 14 pro max running iOS version 16.6.1 while using Safari to visit the homepage, pressing the install to home screen button and then pressing the close button immediately prevents the user from scrolling page.

https://github.com/DannyMoerkerke/whatpwacando.today/assets/20451159/f0c18541-d3f3-43c4-9fb5-c9ed7aed331f

Rabithua commented 8 months ago

It looks like some mechanism is used to prevent scroll penetration, and this mechanism is not cleared after close.

DannyMoerkerke commented 8 months ago

This looks like an iOS bug since I'm able to reproduce this on iOS 16.4 and 17 but not on iOS 17.2 The dialog is a native <dialog> element and it seems this doesn't play well with the scrolling <div> that has overflow: hidden. I noticed that when I give it overflow: auto when the <dialog> is closed and then revert it to overflow: hidden with a short delay, the problem is fixed.

I deployed this fix, could you please check on your side as well?

gaber85 commented 8 months ago

@DannyMoerkerke Yep it's working now. 👌 Thanks for the quick turnaround!