search

DannyWatsonNZ / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #3

Open farishkash opened 7 years ago

farishkash commented 7 years ago

Your project was really good. The only issue I had was the lack of divs. You did try to reduce some of your css usage with this section.

html { font-family: Helvetica; }

My goal is to try to get you to think of reducing css always so you have to type less.

So change your site over to divs, find ways to reduce your css. After that take a look at bootstrap, http://getbootstrap.com/ . Think about or even try to add this into your website and experiment with it to make it mobile friendly. It does a good job teaching you reusability in your css also.

DannyWatsonNZ commented 7 years ago

Thank you for your suggestions above. Can you please take a look at my comment regarding use of divs?

DannyWatsonNZ commented 7 years ago

New version of project submitted for further review.

farishkash commented 7 years ago

You did a great job just one minor error

https://github.com/DannyWatsonNZ/prj-rev-bwfs-dasmoto/blob/master/DasmotoArtsAndCrafts/index.html#L29

You can remove the class from your spans, you probably just missed this.

DannyWatsonNZ commented 7 years ago

Final (hopefully) version of project for review.