Closed mlipok closed 2 years ago
This code looks familiar.
Yes. It is yours example. By this PR I just wanted to show that we should add this as a demo.
- The
IsKeyword
coding in the ConsoleWrite is incomplete. My original plan was to use a ternary operator to display "null" when the result of the function call is null.
If this is needed please provide fix.
- Does the additional _WD_ExecuteScript at the bottom add any real value? IMO, it is performing the exact same action as _WD_Storage.
yes it shows that it is accesible in browser (shows results in browser console).
How will the user known to check the browser console?
If user want to know how to work with browser automation then he must to learn how to use browser console.
Lastly, I question whether this example should be included in wd_demo because it is likely that most coders will never use _WD_Storage.
Good point, I was not thinking about this in such way. Leaving it to you - you can close or merge.
Let's leave this out for now.
Pull request
Proposed changes
added separate examples as
DemoStorage
Checklist
Types of changes
Please check
x
the type of change your PR introduces:What is the current behavior?
before merging new feature
What is the new behavior?
added separate examples as
DemoStorage
Additional context
none
System under test
not related