__WD_DetectError: frame not found detection

Danp2 commented 1 year ago

Pull request

Proposed changes

Add detection for failure to locate a frame

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!
This is simply a reminder of what we are going to look for before merging your code.

[x] I have read and noticed the CODE OF CONDUCT document
[x] I have read and noticed the CONTRIBUTING document
[ ] I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

[ ] Bugfix (change which fixes an issue)
[x] Feature (change which adds functionality)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (functional, structural)
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

Generic $_WD_ERROR_Exception is returned when the frame can't be located

What is the new behavior?

$_WD_ERROR_NoMatch is returned

Additional context

Add any other context about the problem here.

System under test

Please complete the following information.

OS: [e.g. Windows 10]
OS Arch.: [e.g. X64]
Browser [e.g. firefox]
Browser version [e.g. 96.0.3]

mlipok commented 1 year ago

Looks good. but... _WD_FrameEnter header should be suplemented. https://github.com/Danp2/au3WebDriver/blob/7b4a109e695aba1d4e2a21028a53fc48a47ff1bf/wd_helper.au3#L630-L632

and this line too: https://github.com/Danp2/au3WebDriver/blob/7b4a109e695aba1d4e2a21028a53fc48a47ff1bf/wd_helper.au3#L698-L700

Danp2 commented 1 year ago

@mlipok That will come in a separate PR.

Danp2 / au3WebDriver