Functions should be checked for escaping strings

[mlipok]

_WD_Storage() SET should be checked if $vValue should be escaped with __WD_EscapeString() _WD_Storage() GET should be checked if $vResult should be de escaped with Json_StringDecode()

Originally posted by @mlipok in https://github.com/Danp2/au3WebDriver/issues/469#issuecomment-1537521321

[Danp2]

@mlipok Please share your thoughts on this. Why do you think further encoding / decoding is needed here?

Shouldn't the user be responsible for encoding / decoding the string outside of _WD_Storage when needed?

[Danp2]

Also, see https://github.com/Danp2/au3WebDriver/issues/466#issuecomment-1523859474, which could also be the solution here.

[mlipok]

_WD_GetElementByRegEx() https://github.com/Danp2/au3WebDriver/blob/81154aba09b8d2f894170b276659ce99f26b8fd0/wd_helper.au3#L3059-L3075

@TheDcoder I wonder is this StringReplace still needed ? https://github.com/Danp2/au3WebDriver/blob/81154aba09b8d2f894170b276659ce99f26b8fd0/wd_helper.au3#L3073

I mean after we changed how __WD_EscapeString is used: https://github.com/Danp2/au3WebDriver/pull/469/files

_WD_ExecuteScript() usage

and __WD_EscapeString()

[TheDcoder]

@mlipok Not sure really, the change is complicated and I have forgotten the context. Best if you trace it out and see if it's still required :smile:

[Danp2]

https://github.com/Danp2/au3WebDriver/blob/81154aba09b8d2f894170b276659ce99f26b8fd0/wd_helper.au3#L3073 Based on my testing, this line is no longer required.

[mlipok]

Any testing snippet ?

[Danp2]

https://github.com/Danp2/au3WebDriver/pull/301#issuecomment-1137863798

😆

[mlipok]

my memory doesn't go that far ;)

[Danp2]

Regarding _WD_Storage, I would suggest that this be handled in the same way as I recommend in https://github.com/Danp2/au3WebDriver/issues/466#issuecomment-1544627814