Closed Danp2 closed 1 year ago
The new JSON API endpoints are nice, but using them may require reworking the existing implementation since you can no longer obtain the latest release for a single milestone. For example, here's the resulting JSON from https://googlechromelabs.github.io/chrome-for-testing/latest-versions-per-milestone-with-downloads.json --
```json { "timestamp": "2023-05-17T14:08:11.783Z", "milestones": { "113": { "milestone": "113", "version": "113.0.5672.63", "revision": "1121455", "downloads": { "chrome": [ { "platform": "linux64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.63/linux64/chrome-linux64.zip" }, { "platform": "mac-arm64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.63/mac-arm64/chrome-mac-arm64.zip" }, { "platform": "mac-x64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.63/mac-x64/chrome-mac-x64.zip" }, { "platform": "win32", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.63/win32/chrome-win32.zip" }, { "platform": "win64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.63/win64/chrome-win64.zip" } ] } }, "114": { "milestone": "114", "version": "114.0.5735.26", "revision": "1135570", "downloads": { "chrome": [ { "platform": "linux64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/114.0.5735.26/linux64/chrome-linux64.zip" }, { "platform": "mac-arm64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/114.0.5735.26/mac-arm64/chrome-mac-arm64.zip" }, { "platform": "mac-x64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/114.0.5735.26/mac-x64/chrome-mac-x64.zip" }, { "platform": "win32", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/114.0.5735.26/win32/chrome-win32.zip" }, { "platform": "win64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/114.0.5735.26/win64/chrome-win64.zip" } ] } }, "115": { "milestone": "115", "version": "115.0.5776.0", "revision": "1144913", "downloads": { "chrome": [ { "platform": "linux64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/linux64/chrome-linux64.zip" }, { "platform": "mac-arm64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/mac-arm64/chrome-mac-arm64.zip" }, { "platform": "mac-x64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/mac-x64/chrome-mac-x64.zip" }, { "platform": "win32", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/win32/chrome-win32.zip" }, { "platform": "win64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/win64/chrome-win64.zip" } ], "chromedriver": [ { "platform": "linux64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/linux64/chromedriver-linux64.zip" }, { "platform": "mac-arm64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/mac-arm64/chromedriver-mac-arm64.zip" }, { "platform": "mac-x64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/mac-x64/chromedriver-mac-x64.zip" }, { "platform": "win32", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/win32/chromedriver-win32.zip" }, { "platform": "win64", "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5776.0/win64/chromedriver-win64.zip" } ] } } } } ```
To use the existing functionality, the Regex would need to know which milestone (113, 114, or 115) is being targeted.
as an answer to: https://github.com/Danp2/au3WebDriver/pull/477#issuecomment-1574890073 I think we should copy old settings:
["chrome", "chrome.exe", "chromedriver.exe", False, "goog:chromeOptions", "'https://chromedriver.storage.googleapis.com/LATEST_RELEASE_' & StringLeft($sBrowserVersion, StringInStr($sBrowserVersion, '.') - 1)", "", '"https://chromedriver.storage.googleapis.com/" & $sDriverLatest & "/chromedriver_win32.zip"'],
for example:
["chromeold", "chrome.exe", "chromedriver.exe", False, "goog:chromeOptions", "'https://chromedriver.storage.googleapis.com/LATEST_RELEASE_' & StringLeft($sBrowserVersion, StringInStr($sBrowserVersion, '.') - 1)", "", '"https://chromedriver.storage.googleapis.com/" & $sDriverLatest & "/chromedriver_win32.zip"'],
just simply chrome >> chromeold
EDIT: for reference: similar case was raisen here: https://www.autoitscript.com/forum/topic/208640-webdriver-udf-help-support-iv/?do=findComment&comment=1519048
Looks fine.
Bug report
Describe the bug
From here --
How to reproduce
N/A
Expected behavior
_WD_UpdateDriver
will continue to work correctly with future releases of ChromeDriverTo Do