Danp2 / au3WebDriver

Web Driver UDF for AutoIt
MIT License
107 stars 21 forks source link

Update chromedriver support #477

Closed Danp2 closed 1 year ago

Danp2 commented 1 year ago

Pull request

Proposed changes

Support new release process for Chromedriver

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!
This is simply a reminder of what we are going to look for before merging your code.

Types of changes

Please check x the type of change your PR introduces:

What is the current behavior?

See #473

What is the new behavior?

Additional context

Add any other context about the problem here.

System under test

Please complete the following information.

Danp2 commented 1 year ago

Note

Once this PR is merged, only Chrome v115 (scheduled to be released in mid-July) and later will be supported. Earlier versions will return an error --

    _WD_UpdateDriver ==> Not found [13 / 0] : DriverCurrent = 0 : DriverLatest = 113.0.5672.63

mlipok commented 1 year ago

I wonder if we should support both old and new ?

Danp2 commented 1 year ago

I considered it, but I didn't see a good way to allow this within the existing implementation. If you have ideas or you want to discuss more, then I suggest moving the discussion to #473

mlipok commented 1 year ago

As so far not tested, but looks good.