Danp2 / au3WebDriver

Web Driver UDF for AutoIt
MIT License
107 stars 21 forks source link

_WD_GetElementFromPoint: Detect invalid coordinates #490

Closed Danp2 closed 1 year ago

Danp2 commented 1 year ago

Pull request

Proposed changes

Return additional error code to indicate invalid parameters.

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!
This is simply a reminder of what we are going to look for before merging your code.

Types of changes

Please check x the type of change your PR introduces:

What is the current behavior?

Empty string is returned, but no error code is generated

What is the new behavior?

Sets @err to $_WD_ERROR_InvalidArgue if a negative coordinate is detected

Additional context

Add any other context about the problem here.

System under test

Please complete the following information.

mlipok commented 1 year ago

Looks good as so far.