__WD_ErrHnd added notification to __WD_Error - Githubissues

Danp2 / au3WebDriver

Web Driver UDF for AutoIt

MIT License

107 stars 21 forks source link

__WD_ErrHnd added notification to __WD_Error #513

Open mlipok opened 6 months ago

mlipok commented 6 months ago

Pull request

Proposed changes

__WD_ErrHnd should do some notification to __WD_Error

Checklist

[x] I have read and noticed the CODE OF CONDUCT document
[x] I have read and noticed the CONTRIBUTING document
[ ] I have added necessary documentation or screenshots (if appropriate)

Types of changes

[ ] Bugfix (change which fixes an issue)
[x] Feature (change which adds functionality)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (functional, structural)
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

no information about COM Error reasons.

What is the new behavior?

__WD_ErrHnd added notification to __WD_Error

Influences and relationship to other functionality

none

Additional context

https://github.com/Danp2/au3WebDriver/pull/512

System under test

not related

mlipok commented 4 months ago

btw. please also take a look on: __WD_ErrHnd() >> $_WD_ERROR_GeneralError

I think we can not put different error number than defined in UDF.

Because it is used here: https://github.com/Danp2/au3WebDriver/blob/3cc6ce35eb388230da29d027392a832604187c99/wd_core.au3#L1670

For this reason propse this change.