search

Dante383 / VLC-GIF-Maker

Extension to the VLC player which allows you to easily generate GIFs from watched content
MIT License
17 stars 1 forks source link

Windows : No gif created #1

Open Cronos-lab opened 1 year ago

Cronos-lab commented 1 year ago

Hello, It's the first time I've tried a VLC extension. I'm on Windows and it doesn't work. I've ffmpeg.

I have the menu with plugin but I have no VLC confirmation when I press Generate GIF. I have nothing, my folder is empty.

Thank you so much.

MyNameIsTroll commented 1 year ago

The same thing for me, I put the .lua file in C:\Program Files\VideoLAN\VLC\lua\extensions I installed ffmpeg and added to the windows PATH ( C:\ffmpeg\bin ) but when I use the extension, it does not create .gif

Dante383 commented 1 year ago

Hi, thanks for information! I'll check on a Windows machine and get back to you, it's probably an issue with path generation

Dante383 commented 1 year ago

Okay, fixed and tested, works for me. Still doesn't work if there is [, ], + or - in the input or output path, working on that.

AdamDyrda commented 1 year ago

Hi, it still doesn't work for me. Am I doing something wrong or what?

Dante383 commented 1 year ago

@TheGr0ke are you using the latest vlc_gif_maker.lua from the repository? I didn't publish a new version yet, gonna do it later today after fixing the characters mentioned above. If you're using the latest version, in VLC click Tools -> Messages, change debug level to 2. Command should be printed after clicking "Generate GIF". Send it here if you could, I'll see what's wrong

AdamDyrda commented 1 year ago

main debug: toggling pause main debug: toggling pause mmdevice debug: state changed: 1 main debug: auto hiding mouse cursor qt debug: activating or triggering extension 'VLC GIF maker' lua debug: Activating extension 'VLC GIF maker' main debug: auto hiding mouse cursor lua debug: Creating dialog 'GIF Maker' qt debug: Creating a new dialog: 'GIF Maker' lua debug: Clicking 'C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua': 'Get' main debug: auto hiding mouse cursor main debug: EOF reached lua debug: Clicking 'C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua': 'Get' main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: waiting decoder fifos to empty main debug: killing decoder fourcc h264' main debug: removing module "avcodec" main debug: saving a free vout main debug: reusing provided vout main debug: killing decoder fourccmp4a' main debug: removing module "faad" mmdevice debug: state changed: 0 wasapi debug: reset main debug: removing module "samplerate" main debug: removing module "scaletempo" main debug: removing module "float_mixer" main debug: keeping audio output main debug: removing module "mp4" mp4 debug: freeing all memory main debug: Program doesn't contain anymore ES main debug: removing module "record" main debug: removing module "cache_read" main debug: removing module "filesystem" main debug: dead input main debug: changing item without a request (current 5/6) main debug: nothing to play main debug: destroying useless vout main debug: removing module "direct3d11" direct3d11 debug: Direct3D11 resources destroyed lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found qt debug: IM: Deleting the input direct3d11 debug: Direct3D11 device adapter closed direct3d11 error: SetThumbNailClip failed: 0x800706f4 direct3d11 debug: Win32 Vout EventThread terminating direct3d11 debug: Win32VoutCloseWindow direct3d11 debug: WinProc WM_DESTROY main debug: removing module "inhibit" qt debug: releasing video... qt debug: video widget is released main debug: removing module "freetype" main debug: removing module "yuvp" main debug: removing module "swscale" lua debug: Clicking 'C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua': 'Generate GIF' lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function (null)(): ...AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua:180: attempt to index local 'item' (a nil value) lua warning: Could not translate click main debug: processing request item: you are not immune to kaguya dub_Trim.mp4, node: Playlist, skip: 0 main debug: resyncing on you are not immune to kaguya dub_Trim.mp4 main debug: you are not immune to kaguya dub_Trim.mp4 is at 5 main debug: starting playback of new item main debug: resyncing on you are not immune to kaguya dub_Trim.mp4 main debug: you are not immune to kaguya dub_Trim.mp4 is at 5 main debug: creating new input thread main debug: Creating an input for 'you are not immune to kaguya dub_Trim.mp4' main debug: requesting art for new input thread main debug: using timeshift granularity of 50 MiB main debug: using timeshift path: C:\Users\adame\AppData\Local\Temp main debug: file:///C:/Users/adame/Videos/you%20are%20not%20immune%20to%20kaguya%20dub_Trim.mp4' gives accessfile' demux any' path/C:/Users/adame/Videos/you%20are%20not%20immune%20to%20kaguya%20dub_Trim.mp4' main debug: creating demux: access='file' demux='any' location='/C:/Users/adame/Videos/you%20are%20not%20immune%20to%20kaguya%20dub_Trim.mp4' file='C:\Users\adame\Videos\you are not immune to kaguya dub_Trim.mp4' main debug: looking for access_demux module matching "file": 15 candidates main debug: looking for meta fetcher module matching "any": 1 candidates main debug: no access_demux modules matched main debug: creating access: file:///C:/Users/adame/Videos/you%20are%20not%20immune%20to%20kaguya%20dub_Trim.mp4 main debug: (path: C:\Users\adame\Videos\you are not immune to kaguya dub_Trim.mp4) main debug: looking for access module matching "file": 27 candidates lua debug: Trying Lua scripts in C:\Users\adame\AppData\Roaming\vlc\lua\meta\fetcher lua debug: Trying Lua scripts in C:\Program Files\VideoLAN\VLC\lua\meta\fetcher main debug: using access module "filesystem" main debug: looking for stream_filter module matching "prefetch,cache_read": 24 candidates cache_read debug: Using stream method for AStream* main debug: no meta fetcher modules matched cache_read debug: starting pre-buffering main debug: looking for art finder module matching "any": 2 candidates cache_read debug: received first data after 1 ms cache_read debug: pre-buffering done 1024 bytes in 0s - 999 KiB/s main debug: using stream_filter module "cache_read" main debug: looking for stream_filter module matching "any": 24 candidates lua debug: Trying Lua scripts in C:\Users\adame\AppData\Roaming\vlc\lua\playlist lua debug: Trying Lua scripts in C:\Program Files\VideoLAN\VLC\lua\playlist lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\anevia_streams.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\anevia_xml.luac lua debug: Trying Lua scripts in C:\Users\adame\AppData\Roaming\vlc\lua\meta\art lua debug: Trying Lua scripts in C:\Program Files\VideoLAN\VLC\lua\meta\art lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\art\00_musicbrainz.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\appletrailers.luac lua debug: skipping script (unmatched scope) C:\Program Files\VideoLAN\VLC\lua\meta\art\00_musicbrainz.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\bbc_co_uk.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\art\01_googleimage.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\cue.luac lua debug: skipping script (unmatched scope) C:\Program Files\VideoLAN\VLC\lua\meta\art\01_googleimage.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\art\02_frenchtv.luac lua debug: skipping script (unmatched scope) C:\Program Files\VideoLAN\VLC\lua\meta\art\02_frenchtv.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\dailymotion.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\art\03_lastfm.luac lua debug: skipping script (unmatched scope) C:\Program Files\VideoLAN\VLC\lua\meta\art\03_lastfm.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\jamendo.luac main debug: no art finder modules matched main debug: looking for meta fetcher module matching "any": 1 candidates lua debug: Trying Lua scripts in C:\Users\adame\AppData\Roaming\vlc\lua\meta\fetcher lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\koreus.luac lua debug: Trying Lua scripts in C:\Program Files\VideoLAN\VLC\lua\meta\fetcher main debug: no meta fetcher modules matched main debug: looking for art finder module matching "any": 2 candidates lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\liveleak.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\newgrounds.luac lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found lua debug: Trying Lua scripts in C:\Users\adame\AppData\Roaming\vlc\lua\meta\art lua debug: Trying Lua scripts in C:\Program Files\VideoLAN\VLC\lua\meta\art lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\rockbox_fm_presets.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\art\00_musicbrainz.luac qt debug: IM: Setting an input lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\soundcloud.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\art\01_googleimage.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\twitch.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\art\02_frenchtv.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\vimeo.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\art\03_lastfm.luac lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\vocaroo.luac main debug: no art finder modules matched lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\playlist\youtube.luac main debug: no stream_filter modules matched main debug: looking for stream_directory module matching "any": 1 candidates main debug: no stream_directory modules matched main debug: attachment of directory-extractor failed for file:///C:/Users/adame/Videos/you%20are%20not%20immune%20to%20kaguya%20dub_Trim.mp4 main debug: looking for stream_filter module matching "record": 24 candidates main debug: using stream_filter module "record" main debug: creating demux: access='file' demux='any' location='/C:/Users/adame/Videos/you%20are%20not%20immune%20to%20kaguya%20dub_Trim.mp4' file='C:\Users\adame\Videos\you are not immune to kaguya dub_Trim.mp4' main debug: looking for demux module matching "mp4": 55 candidates mp4 warning: Unknown uuid type box mp4 warning: unknown box type Xtra (incompletely loaded) mp4 debug: dumping root Box "root" mp4 debug: | + ftyp size 24 offset 0 mp4 debug: | + uuid size 40 offset 24 mp4 debug: | + mdat size 6745477 offset 64 mp4 debug: | + moov size 5088 offset 6745541 mp4 debug: | | + mvhd size 108 offset 6745549 mp4 debug: | | + trak size 2261 offset 6745657 mp4 debug: | | | + tkhd size 92 offset 6745665 mp4 debug: | | | + mdia size 2161 offset 6745757 mp4 debug: | | | | + mdhd size 32 offset 6745765 mp4 debug: | | | | + hdlr size 45 offset 6745797 mp4 debug: | | | | + minf size 2076 offset 6745842 mp4 debug: | | | | | + vmhd size 20 offset 6745850 mp4 debug: | | | | | + dinf size 36 offset 6745870 mp4 debug: | | | | | | + dref size 28 offset 6745878 mp4 debug: | | | | | | | + url size 12 offset 6745894 mp4 debug: | | | | | + stbl size 2012 offset 6745906 mp4 debug: | | | | | | + stsd size 148 offset 6745914 mp4 debug: | | | | | | | + avc1 size 132 offset 6745930 mp4 debug: | | | | | | | | + avcC size 46 offset 6746016 mp4 debug: | | | | | | + stts size 24 offset 6746062 mp4 debug: | | | | | | + stsc size 340 offset 6746086 mp4 debug: | | | | | | + stsz size 1284 offset 6746426 mp4 debug: | | | | | | + stco size 148 offset 6747710 mp4 debug: | | | | | | + stss size 60 offset 6747858 mp4 debug: | | + trak size 2601 offset 6747918 mp4 debug: | | | + tkhd size 92 offset 6747926 mp4 debug: | | | + mdia size 2501 offset 6748018 mp4 debug: | | | | + mdhd size 32 offset 6748026 mp4 debug: | | | | + hdlr size 45 offset 6748058 mp4 debug: | | | | + minf size 2416 offset 6748103 mp4 debug: | | | | | + smhd size 16 offset 6748111 mp4 debug: | | | | | + dinf size 36 offset 6748127 mp4 debug: | | | | | | + dref size 28 offset 6748135 mp4 debug: | | | | | | | + url size 12 offset 6748151 mp4 debug: | | | | | + stbl size 2356 offset 6748163 mp4 debug: | | | | | | + stsd size 100 offset 6748171 mp4 debug: | | | | | | | + mp4a size 84 offset 6748187 mp4 debug: | | | | | | | | + esds size 48 offset 6748223 mp4 debug: | | | | | | + stts size 40 offset 6748271 mp4 debug: | | | | | | + ctts size 24 offset 6748311 mp4 debug: | | | | | | + stsc size 40 offset 6748335 mp4 debug: | | | | | | + stsz size 1996 offset 6748375 mp4 debug: | | | | | | + stco size 148 offset 6750371 mp4 debug: | | + udta size 110 offset 6750519 mp4 debug: | | | + meta size 53 offset 6750527 mp4 debug: | | | | + hdlr size 33 offset 6750539 mp4 debug: | | | + Xtra size 49 offset 6750580 (????) mp4 debug: unrecognized major media specification (mp42). mp4 debug: found 2 tracks mp4 debug: track[Id 0x1] read 33 chunk mp4 warning: STTS table of 1 entries mp4 debug: track[Id 0x1] read 316 samples length:10s main debug: selecting program id=0 mp4 debug: adding track[Id 0x1] video (enable) language undef mp4 debug: track[Id 0x2] read 33 chunk mp4 warning: STTS table of 3 entries mp4 warning: CTTS table of 1 entries mp4 debug: track[Id 0x2] read 494 samples length:10s mp4 debug: adding track[Id 0x2] audio (enable) language undef main debug: using demux module "mp4" main debug: looking for a subtitle file in C:\Users\adame\Videos\ main debug: looking for video decoder module matching "any": 19 candidates avcodec debug: using ffmpeg Lavc58.134.100 avcodec debug: CPU flags: 0x000853db avcodec debug: allowing 5 thread(s) for decoding avcodec debug: codec (h264) started avcodec debug: using frame thread mode with 5 threads main debug: using video decoder module "avcodec" main debug: looking for audio decoder module matching "any": 23 candidates main debug: using audio decoder module "faad" main debug: looking for meta reader module matching "any": 2 candidates lua debug: Trying Lua scripts in C:\Users\adame\AppData\Roaming\vlc\lua\meta\reader lua debug: Trying Lua scripts in C:\Program Files\VideoLAN\VLC\lua\meta\reader lua debug: Trying Lua playlist script C:\Program Files\VideoLAN\VLC\lua\meta\reader\filename.luac main debug: no meta reader modules matched main debug: `file:///C:/Users/adame/Videos/you%20are%20not%20immune%20to%20kaguya%20dub_Trim.mp4' successfully opened mp4 debug: track[Id 0x1] using Sync Sample Box (stss) mp4 debug: stss gives 0 --> 0 (sample number) main debug: Buffering 0% avcodec debug: available hardware decoder output format 53 (dxva2_vld) avcodec debug: available hardware decoder output format 118 (d3d11va_vld) avcodec debug: available hardware decoder output format 174 (d3d11) faad warning: decoded zero sample avcodec debug: available software decoder output format 0 (yuv420p) avcodec debug: trying format d3d11va_vld main debug: reusing audio output main debug: looking for aout stream module matching "any": 2 candidates main debug: Buffering 25% main debug: Buffering 50% main debug: Buffering 75% main debug: looking for text renderer module matching "any": 3 candidates main debug: Buffering 100% main debug: Stream buffering done (1250 ms in 3 ms) freetype debug: Using DWrite backend freetype debug: DWrite_GetFamily(): family name: Arial freetype debug: DWrite_ParseFamily(): using font at index 0 with weight 400 for bold: 0, italic: 0 freetype debug: DWrite_ParseFamily(): using font at index 1 with weight 700 for bold: 1, italic: 0 freetype debug: DWrite_ParseFamily(): using font at index 2 with weight 400 for bold: 0, italic: 1 freetype debug: DWrite_ParseFamily(): using font at index 3 with weight 700 for bold: 1, italic: 1 main debug: using text renderer module "freetype" main debug: looking for video converter module matching "any": 24 candidates swscale debug: 32x32 (32x32) chroma: YUVA -> 16x16 (16x16) chroma: RGBA with scaling using Bicubic (good quality) main debug: using video converter module "swscale" main debug: looking for video converter module matching "any": 24 candidates yuvp debug: YUVP to YUVA converter main debug: using video converter module "yuvp" main debug: Deinterlacing available main debug: deinterlace -1, mode auto, is_needed 0 main debug: looking for vout window module matching "qt,any": 3 candidates qt debug: requesting video window... wasapi debug: buffer size : 96000 frames wasapi debug: maximum latency: 000 ns wasapi debug: default period : 10000000 ns wasapi debug: minimum period : 3000000 ns main debug: using aout stream module "wasapi" main debug: output 'f32l' 48000 Hz Stereo frame=1 samples/8 bytes main debug: looking for audio volume module matching "any": 2 candidates main debug: using audio volume module "float_mixer" main debug: input 'f32l' 48000 Hz Stereo frame=1 samples/8 bytes main debug: looking for audio filter module matching "scaletempo": 16 candidates scaletempo debug: format: 48000 rate, 2 nch, 4 bps, fl32 scaletempo debug: params: 30 stride, 0.200 overlap, 14 search scaletempo debug: 1.000 scale, 1440.000 stride_in, 1440 stride_out, 1152 standing, 288 overlap, 672 search, 2400 queue, fl32 mode main debug: using audio filter module "scaletempo" main debug: conversion: 'f32l'->'f32l' 48000 Hz->48000 Hz Stereo->Stereo main debug: conversion pipeline complete main debug: conversion: 'f32l'->'f32l' 48000 Hz->48000 Hz Stereo->Stereo main debug: conversion pipeline complete main debug: looking for audio resampler module matching "any": 3 candidates main debug: using audio resampler module "samplerate" lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found main debug: resized to 1280x720 main debug: using vout window module "qt" main debug: looking for inhibit module matching "any": 1 candidates main debug: using inhibit module "inhibit" main debug: Opening vout display wrapper main debug: looking for vout display module matching "any": 12 candidates direct3d11 debug: creating Vout EventThread direct3d11 debug: Win32VoutCreateWindow main debug: VoutDisplayEvent 'resize' 1280x720 direct3d11 debug: created video sub-window direct3d11 debug: Vout EventThread running main debug: resized to 1920x944 main debug: VoutDisplayEvent 'resize' 1920x944 direct3d11 debug: Created the D3D11 device type 1 level b100. direct3d11 debug: NVIDIA WDDM driver 31.0.15.1694 direct3d11 debug: supports colorspace RGB Rec.709 gamma:22 range:FULL direct3d11 debug: supports colorspace RGB Rec.709 gamma:22 range:STUDIO direct3d11 debug: supports colorspace RGB Rec.2020 gamma:22 range:STUDIO direct3d11 debug: supports colorspace RGB Rec.2020 gamma:22 range:FULL direct3d11 debug: supports colorspace RGB Rec.2020 gamma:2084 range:FULL direct3d11 debug: supports colorspace RGB Rec.2020 gamma:2084 range:STUDIO direct3d11 debug: Output max luminance: 270.0, colorspace RGB Rec.709 gamma:22 range:FULL, bits per pixel 8 direct3d11 debug: using colorspace RGB Rec.709 gamma:22 range:FULL direct3d11 debug: Using pixel format VA_NV12 for chroma DX11 main debug: VoutDisplayEvent 'resize' 1296x759 direct3d11 debug: using GPU render fence direct3d11 debug: Direct3D11 resources created direct3d11 debug: Direct3D11 device adapter successfully initialized direct3d11 debug: Direct3D11 Open Succeeded main debug: using vout display module "direct3d11" direct3d11 debug: D3D11 pool succeed with 38 surfaces (1280x768) context 0x000002b452dc0570 main debug: original format sz 1280x720, of (0,0), vsz 1280x720, 4cc DX11, sar 1:1, msk r0x0 g0x0 b0x0 main debug: removing module "freetype" main debug: VoutDisplayEvent 'resize' 1920x944 main debug: looking for text renderer module matching "any": 3 candidates direct3d11 debug: Detected size change 1678x944 freetype debug: Using DWrite backend freetype debug: DWrite_GetFamily(): family name: Arial freetype debug: DWrite_ParseFamily(): using font at index 0 with weight 400 for bold: 0, italic: 0 freetype debug: DWrite_ParseFamily(): using font at index 1 with weight 700 for bold: 1, italic: 0 freetype debug: DWrite_ParseFamily(): using font at index 2 with weight 400 for bold: 0, italic: 1 freetype debug: DWrite_ParseFamily(): using font at index 3 with weight 700 for bold: 1, italic: 1 main debug: using text renderer module "freetype" main debug: looking for hw decoder module matching "any": 2 candidates d3d11va debug: NVIDIA WDDM driver 31.0.15.1694 d3d11va debug: Reusing Direct3D11 device d3d11va debug: CreateDevice succeed d3d11va debug: - 'MPEG-2 & MPEG-1 variable-length decoder' is supported d3d11va debug: - 'MPEG-2 variable-length decoder' is supported d3d11va debug: - 'MPEG-1 variable-length decoder, no D pictures' is supported d3d11va debug: - 'VC-1 variable-length decoder' is supported d3d11va debug: - 'VC-1 variable-length decoder' is supported d3d11va debug: - 'Unknown decoder 0x32fcfe3f-0xde46-0x4a49-0x861bac71110649d5' is supported d3d11va debug: - 'H.264 stereo high profile, mbs flag set' is supported d3d11va debug: - 'H.264 stereo high profile' is supported d3d11va debug: - 'H.264 variable-length decoder, no film grain technology' is supported d3d11va debug: - 'HEVC Main profile' is supported d3d11va debug: - 'HEVC Main 10 profile' is supported d3d11va debug: - 'Unknown decoder 0x20bb8b0a-0x97aa-0x4571-0x8e9964e60606c1a6' is supported d3d11va debug: - 'Unknown decoder 0x15df9b21-0x06c4-0x47f1-0x841ea67c97d7f312' is supported d3d11va debug: - 'MPEG-4 Part 2 variable-length decoder, Simple Profile' is supported d3d11va debug: - 'MPEG-4 Part 2 variable-length decoder, Simple&Advanced Profile, no GMC' is supported d3d11va debug: - 'MPEG-4 Part 2 nVidia bitstream decoder' is supported d3d11va debug: - 'Unknown decoder 0x33fcfe41-0xde46-0x4a49-0x861bac71110649d5' is supported d3d11va debug: - 'VP9 profile 0' is supported d3d11va debug: - 'VP9 profile 2' is supported d3d11va debug: - 'Unknown decoder 0xdda19dc7-0x93b5-0x49f5-0xa9b32bda28a2ce6e' is supported d3d11va debug: - 'Unknown decoder 0x6affd11e-0x1d96-0x42b1-0xa21593a31f09a53d' is supported d3d11va debug: - 'Unknown decoder 0x914c84a3-0x4078-0x4fa9-0x984ce2f262cb5c9c' is supported d3d11va debug: Trying to use 'H.264 variable-length decoder, no film grain technology' as input d3d11va debug: NV12 output is supported for decoder H.264 variable-length decoder, no film grain technology. d3d11va debug: Using output format NV12 for decoder H.264 variable-length decoder, no film grain technology d3d11va debug: va_pool_SetupDecoder id 27 1280x720 count: 23 d3d11va warning: not enough decoding slices in the texture (6/23) d3d11va debug: ID3D11VideoDecoderOutputView succeed with 23 surfaces (1280x720) d3d11va debug: we got 3 decoder configurations d3d11va debug: configuration[0] ConfigBitstreamRaw 1 d3d11va debug: configuration[1] ConfigBitstreamRaw 2 d3d11va debug: configuration[2] ConfigBitstreamRaw 2 d3d11va debug: DxCreateDecoderSurfaces succeed main debug: using hw decoder module "d3d11va" avcodec info: Using D3D11VA (NVIDIA GeForce GTX 1050 Ti, vendor 10de(NVIDIA), device 1c82, revision a1) for hardware decoding main debug: Received first picture main debug: Decoder wait done in 712 ms main debug: inserting 1456 zeroes mmdevice debug: state changed: 1 lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found lua warning: Error while running script C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua, function meta_changed() not found main debug: auto hiding mouse cursor main debug: toggling resume mmdevice debug: state changed: 0 main debug: toggling resume avcodec error: hardware acceleration picture allocation failed lua debug: Clicking 'C:\Users\adame\AppData\Roaming\vlc\lua\extensions\vlc_gif_maker.lua': 'Generate GIF' lua info: ffmpeg -ss 0:0:6.0 -to 0:0:9.0 -i C:/Users/adame/Videos/you main debug: auto hiding mouse cursor main debug: auto hiding mouse cursor

Dante383 commented 1 year ago

@TheGr0ke thanks, you're affected by the special characters issue I'm still working on, certain characters in the file or folder name cause the command to be cut. For temporary solution, you could rename the movie file to a simpler name, should work until I fix it. Care to share the filename of the input video you're trying to use?

AdamDyrda commented 1 year ago

the file name is "you are not immune to kaguya dub_Trim"

AdamDyrda commented 1 year ago

i checked for myself and it's caused by spaces existing in filename

Dante383 commented 1 year ago

@TheGr0ke that was it, thank you! Space was actually the first character I fixed so I didn't even suspect it, turns out I removed the fix at some point of debugging. @MyNameIsTroll @AstroFR: I just released latest version (0.0.5), it should all work now! Let me know if it's fixed

AdamDyrda commented 1 year ago

@Dante383 I'm sorry to tell you but the issue with space is still the same

Cronos-lab commented 1 year ago

I was able to create my first gif with the extension. But in fact for some videos it is impossible. I don't know why. It must depend on the codec.

I tested the extension on 5 videos and the extension worked on only one.

Dante383 commented 1 year ago

At first wanted to thank you guys for creating GitHub (seemingly) just to inform me of the issue. Appreciate it, trying to return the favor by fixing Windows schenigans. Gotta admit, I didn't even test it on Windows, I assumed just switching from (/) to (\) in file paths would be enough, but apparently Microsoft must've felt the need for some 1985 Windows 1.0.1 compatibility or something and it requires special treatment.

@TheGr0ke can confirm, which is really weird because I specifically tested it with spaces before pushing it to the repository. I just downloaded the latest version on my Windows machine and can confirm it's not working, despite the code being identical. I'm feeling pretty puzzled, I'm gonna tackle this later this week after sorting out work stuff.

@AstroFR are you sure it depends on the codec, not the filename? Whole path matters, so this issue with space will still be present if the file doesn't contain any spaces, but one of the folders above it does contain a space. (or some really weird special character). Not sure if ffmpeg does stuff differently on Windows, but you can check yourself. Here's the default extension command:

ffmpeg -ss 00:00:30 -to 00:00:50 -i "<INPUT>" -vf "fps=30,scale=498:-1:flags=lanczos,split[s0][s1];[s0]palettegen[p];[s1][p]paletteuse" -loop 0 "C:\Users\<USER>\Desktop\codectest.gif

I already pre-filled everything, replace<INPUT> with path to the input video and <USER> with your username. Open command line (win+r, then cmd.exe) and it will either create a codectest.gif file on your desktop, or ffmpeg will tell you what the problem is. Will work with space and all weird characters, the extension's issue is in generating the command.

nobef commented 1 year ago

The same thing, in VLC it says that the file has been created, nothing is in place. Windows 10

phevax commented 1 year ago

At first wanted to thank you guys for creating GitHub (seemingly) just to inform me of the issue. Appreciate it, trying to return the favor by fixing Windows schenigans. Gotta admit, I didn't even test it on Windows, I assumed just switching from (/) to () in file paths would be enough, but apparently Microsoft must've felt the need for some 1985 Windows 1.0.1 compatibility or something and it requires special treatment.

@TheGr0ke can confirm, which is really weird because I specifically tested it with spaces before pushing it to the repository. I just downloaded the latest version on my Windows machine and can confirm it's not working, despite the code being identical. I'm feeling pretty puzzled, I'm gonna tackle this later this week after sorting out work stuff.

@AstroFR are you sure it depends on the codec, not the filename? Whole path matters, so this issue with space will still be present if the file doesn't contain any spaces, but one of the folders above it does contain a space. (or some really weird special character). Not sure if ffmpeg does stuff differently on Windows, but you can check yourself. Here's the default extension command:

ffmpeg -ss 00:00:30 -to 00:00:50 -i "<INPUT>" -vf "fps=30,scale=498:-1:flags=lanczos,split[s0][s1];[s0]palettegen[p];[s1][p]paletteuse" -loop 0 "C:\Users\<USER>\Desktop\codectest.gif

I already pre-filled everything, replace<INPUT> with path to the input video and <USER> with your username. Open command line (win+r, then cmd.exe) and it will either create a codectest.gif file on your desktop, or ffmpeg will tell you what the problem is. Will work with space and all weird characters, the extension's issue is in generating the command.

Thank you for this. I was able to successfully create gifs using this command, however the actual VLC GIF Maker extension you've developed doesn't work at all. To be fair I haven't tried it on many different files, but the fact that it worked with your FFMPEG line of code but not within the actual VLC App with the extension running is very odd. Hopefully this is something you'll be able to fix, since running the code manually is a bit tiresome. I should note I am having the same issues as others, I click "create gif", then it says success, but nothing actually happens. It almost feels like no command is even being attempted to run in the background that's how quick it fails. If you have any questions about my paths/setup that could help you identify the problem please let me know.

DorKatzir commented 5 months ago

The same thing, in VLC it says that the file has been created, nothing is in place. Windows 10 your plugin also not letting me to change the path slah to the right direction

q-l-p commented 4 months ago

The Get buttons sometimes acquire a start_timestamp that is greater than the stop_timestamp despite the fact that the user selected correctly in VLC a start time that precedes the stop time. No GIF will be generated in this case.

Dante383 commented 4 months ago

@DorKatzir

The same thing, in VLC it says that the file has been created, nothing is in place. Windows 10 your plugin also not letting me to change the path slah to the right direction

Oh man, it's still causing issues? Thanks for reaching out. I have limited time right now but if you could;

The best thing you could do for me is copy the command from the Messages window and paste it into cmd.exe/Powershell so it'll tell where it hurts exactly

@q-l-p

The Get buttons sometimes acquire a start_timestamp that is greater than the stop_timestamp despite the fact that the user selected correctly in VLC a start time that precedes the stop time. No GIF will be generated in this case.

Greater by how much? Are we talking sub-second? There's some very basic time conversion in place but other than that, the value comes directly from VLC's current point in the video so I might not be able to do much about that

lakkinzi commented 2 months ago

@Dante383, thanks for your great script - it helps me a lot to make video notes.

I'm not sure if that's the problem - but on linux spaces from vlc.input.item():uri() being encoded as "%20"

ffmeg encloses the file path in " " - and the path breaks. Does it make sense to add a space-filled string to the generateCommand function?

command = string_replace(command, "%20", " ")

The same may apply to the output path.

Also, I would guess that ffmeg's different versions does not always work correctly with the format "0:1:4:444", the leadership requirement is zero. Unfortunately, Windows is not available to me at the moment. If the problem is current, I might do more tests and suggest a PR.

Dante383 commented 2 months ago

Hi, thanks for your input! Sadly I have no idea and "it works for me". Due to extremely limited time I cannot investigate this right now but I'll gladly accept a pull request if you feel like chasing the issue

-------- Original Message -------- On 9/7/24 17:01, Lushnikov Stanislav wrote:

@.***(https://github.com/Dante383), thanks for your great script - it helps me a lot to make video notes.

I'm not sure if that's the problem - but on linux I've saw: Spaces from vlc.input.item():uri() being encoded as "%20"

ffmeg encloses the file path in " " - and the path breaks. Does it make sense to add a space-filled string to the generateCommand function?

command = string_replace(command, "%20", " ")

The same may apply to the output path

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

RobertZickler commented 1 month ago

I can not directly reproduce. The script works for me and my videos/gif. But reading the following

can confirm, which is really weird because I specifically tested it with spaces before pushing it to the repository. I just downloaded the latest version on my Windows machine and can confirm it's not working, despite the code being identical. I'm feeling pretty puzzled, I'm gonna tackle this later this week after sorting out work stuff.

a bell ringed and I could imagine the following:

If you download the LUA file from GitHub with "download raw file" the line ending is "LF". If you copy and paste the script from "raw" view in the browser, you get "CRLF". I do that sometimes if I don't need the repo. Or if I changed the file and want to go back to the repo version. Anyway: Windows loves CRLF and can give you wired and hard to track down issues. Especially with scripts and string inputs. If you e.g. have a BAT file with LF == nightmare.

Git in its default config will set the line ending to the system default on a commit.

I don't know how "LF/CRLF"-sensitive LUA is. And if it even matters.