search

Dante83 / A-Starry-Sky

A Realistic Skybox for A Frame! :D
MIT License
63 stars 7 forks source link

Support for aframe 1.5.0 #6

Open gmarty opened 5 months ago

gmarty commented 5 months ago

Hi. a-starry-sky is not compatible with the latest version of A-Frame (1.5.0). Fortunately, the only changes required to make it work are renaming some Three.js calls to API that changed.

new THREE.PlaneBufferGeometry => new THREE.PlaneGeometry new THREE.DataTexture3D => new THREE.Data3DTexture new THREE.IcosahedronBufferGeometry => new THREE.IcosahedronGeometry

Once that is done, it seems to work, but there may be breaking changes I haven't noticed.

Dante83 commented 5 months ago

Three always did love changing names XD. Sorry about the late reply, will try and update this over the weekend and see if it all works again. Thanks for letting me know!

Dante83 commented 4 months ago

Something is still off and I'm not getting the sky to show up. But I implemented those changes and I can proceed next weekend to see what might have broke between these two things. There are no blaring errors, only a couple of small deprecation warnings, so I fear the problem might be a little hairy.

PR: https://github.com/Dante83/A-Starry-Sky/pull/7