DanyDin1801 / Product-Portal

0 stars 2 forks source link

Task runner to run JavaScript linter is configured #13

Open JordyVlassembrouck opened 8 years ago

JordyVlassembrouck commented 8 years ago

Using the style guide will definitely improve the quality of our code. However, human errors are not ruled out. Therefore, using a Task runner with a JavaScript linter would help us keep our code clean.

As task runner, I would recommend Gulp. The idea is to create a task that runs a JS linter that checks for style guidelines, unused variables, those sort of things.

vinaypuppal commented 8 years ago

For the build tool i would recommend brunch its easy and the configs are much simpler than Gulp or Webpack.

rhgksrua commented 8 years ago

I have tried a little bit of gulp but not brunch. I would like to see how brunch works so I would go with brunch.

JordyVlassembrouck commented 8 years ago

@vinaypuppal @rhgksrua I have read an interesting article about the pros and cons of grunt, gulp and brunch. Brunch might have a smaller config file, but it is also less flexible and harder than gulp. It all depends on what we want exactly. I like the fact that gulp is easy and flexible. What are your opinions?

rhgksrua commented 8 years ago

I've looked at brunch and if we're only running a linter I'll go with gulp. But if we had to actually build something I would try brunch.

JordyVlassembrouck commented 8 years ago

It's not a problem to run both. They're development tools, so you can personally run Gulp, Brunch or both.

vinaypuppal commented 8 years ago

@JordyVlassembrouck Read that article but it is 2 years old, brunch has evolved much more in these 2 years, i personally see only one difference between brunch and other build tools i.e The Brunch config is declarative, not imperative — you tell Brunch what you want to get, not how to actually do it. So as @rhgksrua said if we run only linter then we can go with Gulp or else brunch would be better option to consider.

rhgksrua commented 8 years ago

We should keep this simple as possible. Using only gulp sounds good. @JordyVlassembrouck can you set up gulp?

JordyVlassembrouck commented 8 years ago

@vinaypuppal @rhgksrua I just took a deeper look at both Gulp and Branch's JSHint plugin. It seems that Brunch is alot less flexible and provides less configuration possibilities than Gulp, so I would actually start with Brunch, and use Gulp if we need more flexibility. For now, we only need a linter, so it seems Brunch will do. What do you think?

rhgksrua commented 8 years ago

I think gulp might be less confusing to others since we don't have to mess around with our current project structure. It looks like the default behavior of brunch is to build and copy files from a assets directory to a public directory. I'm not sure if that can be changed in the config, but in gulp I think we can just run a linter through all the js files and show the result. And nothing gets moved.