search

DanyDin1801 / Product-Portal

0 stars 2 forks source link

update versions concept #14

Closed danydin closed 8 years ago

danydin commented 8 years ago
  1. I've made it as a pull so everyone can share their opinon about version 0.1 what to add / change before we make it 'fixed'
sorinr commented 8 years ago

As i already mentioned, I would also fetch the categories from a json file that allow us to quickly change what we want to be displayed. As for the products, i would fetch all of them once (as they are only 30-40 products in the beginning) and filter them to show only for the category that is active. Fetching them all will also be helpful when using the search input. When clicking on a specific product i would reveal a product page with more info about that product.

rhgksrua commented 8 years ago

I don't see the purpose of categories before any search is made. Are we going to fetch all products in a category if its clicked?

rhgksrua commented 8 years ago

@danydin, I remember you mentioning that we'll show users a random result when they visit the website. Is that feature still included?

JordyVlassembrouck commented 8 years ago

@danydin I don't get the idea behind already creating v0.1, v0.2, v1.0, ... Normally, you start creating versions when you go live. Right now, as this is a private project I don't see the point of versions. It's only extra work that does not have any added value. Also, this is not the idea of a README file. the only thing this should contain is actually everything you need to get up and running with the project. If you want to write documentation, you better create a page on the wiki for that.

danydin commented 8 years ago

@sorinr that's exactly as my planned i might not wrote it the clearest way that's why i pr it first, i'll try to make it clearer now.

@rhgksrua regarding your first question, yes we will fetch the right products on their own respective catgories, how come you don't see a purpose? also search will be included from the 0.1 ver. about your second question, that's right i will add it to the file (thanks for reamainding me)

@JordyVlassembrouck hey Jordy, the version is just for our knowledge purposes nothing more it shouldn't bother you nor anyone else in the team, again it just for knowledge-ideas sharing collberating. about the readme file well becuase it is a private project as you've mention I think it's fine to leave it there right now if you think it's a problmatic for some reasons and the rest will agree i will not have a problem to move it to a page in wiki i just thought as it's simpler and clearer over there for everyone :)

thanks all for your comments 👍

JordyVlassembrouck commented 8 years ago

@danydin ok, you say for knowledge purposes, but what do we actually gain with it?

rhgksrua commented 8 years ago

@danydin The problem with having categories that list all the products is that amazon api and the one you mentioned before does not have a way to search by category name. We might implement categories but we might not have any use for it. If you can give me one api that returns products based on category alone, then I don't have problem with implementing categories.

Also, you said that a pop up with more info will appear if some one clicks on a product. Are we only showing details about the product? Is there going to be any buttons? Links?

JordyVlassembrouck commented 8 years ago

If you really want to do this, I would write your additional info in a separate file, DETAILS.md perhaps. A README should only contain everything you need to get up and running with the project, nothing more, nothing less. You should not just dump everything in the README.

rhgksrua commented 8 years ago

The README.md looks good for now, but can you merge it to develop branch? So when people branch off of develop they don't have to go look at master branch for clarification. Looks like no one has anything to say so you can merge it.