search

DanyDin1801 / Product-Portal

0 stars 2 forks source link

Display products from a static JSON #15

Closed arreche closed 8 years ago

arreche commented 8 years ago

This is a scaffold which displays an ugly list of products from a dummy Json.

screen shot 2016-08-30 at 1 26 32 pm

rhgksrua commented 8 years ago

Can you make this pull request to develop branch?

arreche commented 8 years ago

May I merge this pull request as it is now?

khawajaAtteeq commented 8 years ago

Okay First I need guide lines how are we going to do stuff using git as I've only used it with Visual Studio and their its a button click second as I was reading the discussion on the chat room: some thing was said about using of a framework so? My question is: with what? and when are we going to start...

rhgksrua commented 8 years ago

@arreche, Can you just move all the functions in index.js to displayResults.js and only append product lists in index.js. Can you also only include displayResults.js in karma config files or exclude index.js. Also, add displayResults.js to html. Then I say it's good for now unless anyone else wants say something.

@khawajaAtteeq, I have hard time understanding what you're trying to say. You want to know how git work?

arreche commented 8 years ago

@rhgksrua Sure! I can do that ;)

@khawajaAtteeq Thank you so much for participating! Well done! :)

  1. There is a nice course to introduce yourself about how to use git and github outside any visual IDE or editor at https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github
  2. We already started! Nobody is going to tell you what you have to do. Just read the project description, follow the Github discussion and participate. The goal is to implement something like this https://github.com/DanyDin1801/Product-Portal/tree/danydin
rhgksrua commented 8 years ago

Can you append products list to div element, not the document.body?

rhgksrua commented 8 years ago

Everything looks good. Go ahead and merge it.