DanyDin1801 / Product-Portal

0 stars 2 forks source link

Add detailed tasks list to the ready tab #22

Open danydin opened 8 years ago

danydin commented 8 years ago
rhgksrua commented 8 years ago

I have some issues with what you have here. Right now, what you have wrote down is how this project will look like. It has nothing on what people are supposed to do. All the tasks should be divided in a more logical way. Many of the bullet points should be grouped into a single task for a single collaborator. I'm just going to show you how I see this should be handled.

Todo list:

  1. Add nav bar and search bar to html according to project mock up.
    • Categories will be added by fetching categories.json from the server. Talk with task no. 2 for any other issues.
    • Talk with task no. 4 about classnames and any other issues.
    • Read README.md about how products should be displayed (number of categories, number of products per row, and etc.).
  2. Create a function that fetches json from the server api endpoint. Talk with #16 about endpoint url and any query strings.
    • The function should return a json which would be parsed by task no. 3.
  3. Create a function that parses json to an object to fit current products list.
    • Should return an object that can be used by buildProducts() in displayResults.js.
  4. Add a popup for products list. If users click on a product, they should see a pop up of product details.
    • This should be done when product list is created in displayResults.js.
  5. Need to discuss how pagination of products should be handled. Most likely, real world api won't return a complete list of search results. If results exceeds certain number of items, we need to ask for more (usually in the query string, i.e. /?search=computer&pagination=2)

Each of these numbered tasks should be created as a github issue. This will make it easier to talk about any issues or any clarification needed for each task. If people think these tasks can be handled better, they can talk about it.

The tasks I created is just an interpretation of what you have right now. I think we need something better than what we have right now.

vinaypuppal commented 8 years ago

@rhgksrua Your tasks makes more sense to me as well. We can use these for now and tweak as we move on.