search

DanyDin1801 / Product-Portal

0 stars 2 forks source link

Style guide #5

Closed rhgksrua closed 8 years ago

rhgksrua commented 8 years ago

I noticed that there were 2 spaces and 4 spaces indentation. We should decide how we'll indent. More generally, which style guide to follow.

DanyDin1801 commented 8 years ago

for me 2 spaces is enough. but I don't mind either way.

JordyVlassembrouck commented 8 years ago

Maybe this is a good style guide to use for this project? One of the most used JS style guides : https://github.com/airbnb/javascript/tree/es5-deprecated/es5

This style guide says to use 2 spaces, which is ok for me.

rhgksrua commented 8 years ago

airbnb looks good. But I like 4 spaces.

sorinr commented 8 years ago

I will go for 2 spaces. 4 spaces are ok for readability if you don't have too much nested code

rhgksrua commented 8 years ago

2 spaces is fine.

JordyVlassembrouck commented 8 years ago

Cool. I'll update the Wiki.

JordyVlassembrouck commented 8 years ago

Wiki is updated. Airbnb states the usage of 2 spaces, and we decided to follow that.

JordyVlassembrouck commented 8 years ago

Closed.