search

Danyc0 / Society-voting-bot

A Discord bot for doing society elections
Apache License 2.0
2 stars 4 forks source link

custom unique prefixes feature added for the bot #74

Closed raavann closed 2 years ago

raavann commented 2 years ago

Hie, this is a very nice bot, I thought i might add a new feature to it, so the communities could change the prefix as to their liking and get creative. 😄

I checked and tested it and it worked for me.. Ping if you have some issue or need me to do some changes. thanks,

also it would help me out a lot if you could add hacktoberfest-accepted tag on this PR. :) thanks

raavann commented 2 years ago

Hello @Danyc0 Is there a problem with the PR? Please revert back, regards!

Danyc0 commented 2 years ago

Hi, first off thank you for the PR! Unfortunately as at the moment this is a single-guild-per-instance bot, I feel like this could have been implemented as just an extra value environment variable (through dotenv), and would be much simpler. You also mentioned that you've tested it, but I'm a bit confused because you renamed the Bot object to be "client" instead of "bot", which would have broken everything. How much testing did you do? I also feel like your commit message "Update main.py" should be much more descriptive about what it actually changes, but that's a minor thing.

Thanks again, I think I'm going to close this PR, but you're welcome to re-raise it if you're able to take another look at implementing this feature.