Closed fgimian closed 2 years ago
Hello @fgimian, Try this old version. I was using other method before, but @Larpico was getting an issue #7 in domain accounts with the same name as a local account so I merged his pull request. I was thinking in revert it time ago or maybe add a switch. let me know how it works.
Thanks @Danyfirex. I believe you may have meant to link me to the previous commit.
I have tested that version prior to this commit and it performs as expected. That commit sadly has resulted in a very significant delay when running Set-FTA
.
If this approach is really necessary for domain accounts, it may be worth having a specific switch to enable that behaviour instead of making it the default I think.
Huge love and thanks Fotis
Updated. Now by default it uses old SID method. For special case shown in #7 use -DomainSID switch.
Hey there folks, firstly thank you so SO much for writing this and making it open source!!! 😄
I notice that
Set-FTA
was quite slow on my system:e.g.
After some investigation, I found that the local
Get-UserSid
was the main cause of delay. I have always used another approach to obtain the Sid which is shown below:Switching to this approach, I now see a significant improvement in performance:
Just wanted to share this in case you wish to update the script for everyone.
Thanks heaps Fotis