DanzaSeah / pe

0 stars 0 forks source link

For an invalid format for the screen command, the error message is not descriptive enough #3

Open DanzaSeah opened 2 weeks ago

DanzaSeah commented 2 weeks ago

image.png

As seen from the screenshot, the error message for the screencommand when providing an invalid command format only tells the user that the command format was invalid, as well as what the feature does. For the users, who are "third party recruiters", they may not be as technical and may need more descriptive help messages, such as providing the correct usage message, whenever they make an invalid input or else it may hinder their productivity.

nus-se-bot commented 1 week ago

Team's Response

I appreciate the tester’s feedback, but after reviewing the issue, I noticed that the scroll bar clearly indicates additional lines below the visible section, meaning the full error message is already available to the user. As such, I would classify this as Rejected since the current behaviour works as intended.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Oh I see, thank you for the explanation, I missed out the scroll bar on the side. However since the case is that the error message is there but not immediately visible, I would like to point out that as a cosmetic error, since all other commands have the message usage immediately displayed upon an invalid input, without having to scroll down the bar, and the change could have simply been implemented by removing the blank lines above the message usage. This could still inconvenience new users like me who do not notice that we should scroll down to see the message due to the other commands not requiring us to do so.

screen command image.png

other commands image.png image.png image.png image.png image.png image.png image.png image.png image.png


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]